Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 1802303002: Small fix for the timer event plotter. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Small fix for the timer event plotter. Sometimes v8.log entries are cut off, and leave an unpaired quote. Since the log is piped into d8 to run the tick processor, that quote is interpreted to escape a line break. This fix makes sure that we break lines even with unpaired quotes. R=jkummerow@chromium.org Committed: https://crrev.com/9a6069d19415a893834e973edb161f104d706ffe Cr-Commit-Position: refs/heads/master@{#34786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/profviz/composer.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 9 months ago (2016-03-15 12:28:21 UTC) #1
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-15 12:31:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802303002/1
4 years, 9 months ago (2016-03-15 12:32:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 12:54:31 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 12:55:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a6069d19415a893834e973edb161f104d706ffe
Cr-Commit-Position: refs/heads/master@{#34786}

Powered by Google App Engine
This is Rietveld 408576698