Blob support for IDB [Chromium]

content/browser/indexed_db/leveldb/leveldb_transaction.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/leveldb/leveldb_transaction.h"
 
 #include "base/logging.h"
 #include "content/browser/indexed_db/leveldb/leveldb_database.h"
 #include "content/browser/indexed_db/leveldb/leveldb_write_batch.h"
 #include "third_party/leveldatabase/src/include/leveldb/db.h"
@@ skipping 405 matching lines @@
 
 void LevelDBTransaction::NotifyIterators() {
   for (std::set<TransactionIterator*>::iterator i = iterators_.begin();
        i != iterators_.end();
        ++i) {
     TransactionIterator* transaction_iterator = *i;
     transaction_iterator->DataChanged();
   }
 }
 
-scoped_ptr<LevelDBWriteOnlyTransaction> LevelDBWriteOnlyTransaction::Create(
+scoped_ptr<LevelDBUncachedTransaction> LevelDBUncachedTransaction::Create(
     LevelDBDatabase* db) {
-  return make_scoped_ptr(new LevelDBWriteOnlyTransaction(db));
+  return make_scoped_ptr(new LevelDBUncachedTransaction(db));
 }
 
-LevelDBWriteOnlyTransaction::LevelDBWriteOnlyTransaction(LevelDBDatabase* db)
+LevelDBUncachedTransaction::LevelDBUncachedTransaction(LevelDBDatabase* db)
     : db_(db), write_batch_(LevelDBWriteBatch::Create()), finished_(false) {}
 
-LevelDBWriteOnlyTransaction::~LevelDBWriteOnlyTransaction() {
+LevelDBUncachedTransaction::~LevelDBUncachedTransaction() {
   write_batch_->Clear();
 }
 
-void LevelDBWriteOnlyTransaction::Remove(const StringPiece& key) {
+void LevelDBUncachedTransaction::Put(const StringPiece& key,
+                                     const std::string* value) {
+  DCHECK(!finished_);
+  write_batch_->Put(key, *value);
+}
+
+bool LevelDBUncachedTransaction::Get(const StringPiece& key,
+                                     std::string* value,
+                                     bool* found) {
+  *found = false;
+  DCHECK(!finished_);
+
+  bool ok = db_->Get(key, value, found);
+  if (!ok) {
+    DCHECK(!found);

[jsbell, 2013/12/20 00:44:20]

How about:

DCHECK(ok || !found);
return ok;

[ericu, 2014/02/20 00:50:29]

That's nicer, thanks.

+    return false;
+  }
+  return true;
+}
+
+void LevelDBUncachedTransaction::Remove(const StringPiece& key) {
   DCHECK(!finished_);
   write_batch_->Remove(key);
 }
 
-bool LevelDBWriteOnlyTransaction::Commit() {
+bool LevelDBUncachedTransaction::Commit() {
   DCHECK(!finished_);
 
   if (!db_->Write(*write_batch_))
     return false;
 
   finished_ = true;
   write_batch_->Clear();
   return true;
 }
 
 }  // namespace content