Blob support for IDB [Chromium]

content/browser/indexed_db/indexed_db_transaction.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_TRANSACTION_H_
 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_TRANSACTION_H_
 
 #include <queue>
 #include <set>
 #include <stack>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/time/time.h"
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 #include "content/browser/indexed_db/indexed_db_database.h"
 #include "content/browser/indexed_db/indexed_db_database_error.h"
 
 namespace content {
 
+class BlobWriteCallbackImpl;
 class IndexedDBCursor;
 class IndexedDBDatabaseCallbacks;
 
 class IndexedDBTransaction : public base::RefCounted<IndexedDBTransaction> {
  public:
   typedef base::Callback<void(IndexedDBTransaction*)> Operation;
 
   IndexedDBTransaction(int64 id,
                        scoped_refptr<IndexedDBDatabaseCallbacks> callbacks,
                        const std::set<int64>& object_store_ids,
@@ skipping 24 matching lines @@
   }
   IndexedDBBackingStore::Transaction* BackingStoreTransaction() {
     return &transaction_;
   }
   int64 id() const { return id_; }
 
   IndexedDBDatabase* database() const { return database_; }
   IndexedDBDatabaseCallbacks* connection() const { return callbacks_; }
 
   enum State {
-    CREATED,   // Created, but not yet started by coordinator.
-    STARTED,   // Started by the coordinator.
-    FINISHED,  // Either aborted or committed.
+    CREATED,     // Created, but not yet started by coordinator.
+    STARTED,     // Started by the coordinator.
+    COMMITTING,  // In the process of committing, possibly waiting for blobs
+                 // to be written.
+    FINISHED,    // Either aborted or committed.
   };
 
   State state() const { return state_; }
 
   struct Diagnostics {
     base::Time creation_time;
     base::Time start_time;
     int tasks_scheduled;
     int tasks_completed;
   };
 
   const Diagnostics& diagnostics() const { return diagnostics_; }
 
  private:
+  friend class BlobWriteCallbackImpl;
+
+  // TODO(ericu): Report this on the internals page.
+  bool IsStatePastRunning() const {

[jsbell, 2013/12/20 00:44:20]

Nit: The "Running" terminology is dropped (to try and align with the spec) so
this should be renamed too.

[ericu, 2014/02/20 00:50:29]

Done.

+    return state_ == COMMITTING || state_ == FINISHED;
+  }
   friend class base::RefCounted<IndexedDBTransaction>;
   virtual ~IndexedDBTransaction();
 
   void RunTasksIfStarted();
 
   bool IsTaskQueueEmpty() const;
   bool HasPendingTasks() const;
 
+  void BlobWriteComplete(bool success);
   void ProcessTaskQueue();
   void CloseOpenCursors();
+  void CommitPhaseTwo();
 
   const int64 id_;
   const std::set<int64> object_store_ids_;
   const indexed_db::TransactionMode mode_;
 
   bool used_;
   State state_;
   bool commit_pending_;
+  bool blob_write_success_;

[jsbell, 2013/12/20 00:44:20]

This looks like it's unused now?

[ericu, 2014/02/20 00:50:29]

Done.

   scoped_refptr<IndexedDBDatabaseCallbacks> callbacks_;
   scoped_refptr<IndexedDBDatabase> database_;
 
   class TaskQueue {
    public:
     TaskQueue();
     ~TaskQueue();
     bool empty() const { return queue_.empty(); }
     void push(Operation task) { queue_.push(task); }
     Operation pop();
@@ skipping 26 matching lines @@
   bool should_process_queue_;
   int pending_preemptive_events_;
 
   std::set<IndexedDBCursor*> open_cursors_;
   Diagnostics diagnostics_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_TRANSACTION_H_