Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 18023008: Fix run_decoding_tests on xoom. (Closed)

Created:
7 years, 5 months ago by scroggo
Modified:
7 years, 5 months ago
Reviewers:
epoger, borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix run_decoding_tests on xoom. Builder Test-Android-Xoom-Tegra2-Arm7-Debug fails run_decoding_tests due to a couple of images. Add a way in skimage to ignore failures if an image is expected to fail. Add an expectations file for xoom that includes ignore-failure for the two files which are failing. I have created https://code.google.com/p/skia/issues/detail?id=1382 to track the fact that these images fail to decode, despite the bot showing green. R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=9797

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -9 lines) Patch
A + expectations/skimage/base-android-xoom.json View 2 chunks +64 lines, -4 lines 4 comments Download
M tools/skimage_main.cpp View 2 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
https://codereview.chromium.org/18023008/diff/1/expectations/skimage/base-android-xoom.json File expectations/skimage/base-android-xoom.json (left): https://codereview.chromium.org/18023008/diff/1/expectations/skimage/base-android-xoom.json#oldcode1 expectations/skimage/base-android-xoom.json:1: { The previous file here is base-shuttle_ubuntu12_ati5770.json https://codereview.chromium.org/18023008/diff/1/expectations/skimage/base-android-xoom.json File ...
7 years, 5 months ago (2013-06-27 20:09:48 UTC) #1
borenet
LGTM
7 years, 5 months ago (2013-06-27 20:15:15 UTC) #2
scroggo
Committed patchset #1 manually as r9797 (presubmit successful).
7 years, 5 months ago (2013-06-27 20:21:09 UTC) #3
epoger
7 years, 5 months ago (2013-07-08 15:48:01 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698