[telemetry] Add a version of v8.todomvc that runs using ignition

tools/perf/benchmarks/v8.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import shlex
 
 from core import perf_benchmark
 
 from measurements import v8_detached_context_age_in_gc
 from measurements import v8_gc_times
 import page_sets
@@ skipping 120 matching lines @@
 
   @classmethod
   def Name(cls):
     return 'v8.todomvc'
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
 
+class V8TodoMVCIgnition(perf_benchmark.PerfBenchmark):
+  """Measures V8 Execution metrics on the TodoMVC examples using ignition."""
+  page_set = page_sets.TodoMVCPageSet
+
+  def SetExtraBrowserOptions(self, options):
+    existing_js_flags = []
+    for extra_arg in options.extra_browser_args:
+      if extra_arg.startswith('--js-flags='):
+        existing_js_flags.extend(shlex.split(extra_arg[len('--js-flags='):]))
+    options.AppendExtraBrowserArgs([
+        # This overrides any existing --js-flags, hence we have to include the
+        # previous flags as well.
+        '--js-flags="--ignition %s"' % (' '.join(existing_js_flags))
+    ])
+
+  def CreateTimelineBasedMeasurementOptions(self):
+    category_filter = tracing_category_filter.CreateMinimalOverheadFilter()
+    category_filter.AddIncludedCategory('v8')
+    category_filter.AddIncludedCategory('blink.console')
+    options = timeline_based_measurement.Options(category_filter)
+    options.SetLegacyTimelineBasedMetrics([v8_execution.V8ExecutionMetric()])

[rmcilroy, 2016/03/17 15:25:37]

I'm not sure these will capture any compile time for ignition since they look
for V8.CompileFullCode explicitly. I'll land an equivalent trace event for
ignition, but we'll need to update these metrics too before we get any results.

+    return options
+
+  @classmethod
+  def Name(cls):
+    return 'v8.todomvc-ignition'
+
+  @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):

[Sami, 2016/03/15 12:13:55]

Like we discussed this should probably use the deprecated-but-working restart
API (i.e., needs_browser_restart_after_each_page=True) since
https://crrev.com/43f84917812c614b2a38e8e27064c6873ca6cdb0 got reverted.
MemoryInfra also has this bug (crbug.com/594952).

Zhen, can you suggest a way to use the old API from here?

[jochen (gone - plz use gerrit), 2016/03/15 12:19:08]

needs_browser_restart_after_each_page only works with pre-timeline based tests.

For timeline based measurements, you'd have to specify a startup-url (which
works), but then timeline based measurements crashes, because it starts the
tracing controller before the story is run, and expects it to stay active (which
it doesn't when the entire browser is swapped).

[Zhen Wang, 2016/03/15 15:48:44]

This API should not be used. What are the use cases here? Please continue the
discussion in https://bugs.chromium.org/p/chromium/issues/detail?id=594952.
Thanks for finding this. :)

+    return True
+
+
 # Disabled on reference builds because they don't support the new
 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
 @benchmark.Disabled('reference', 'android')  # crbug.com/579546
 @benchmark.Disabled('win')  # https://crbug.com/590747
 class V8InfiniteScroll(_InfiniteScrollBenchmark):
   """Measures V8 GC metrics and memory usage while scrolling the top web pages.
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
 
   page_set = page_sets.InfiniteScrollPageSet
 
   @classmethod
   def Name(cls):
     return 'v8.infinite_scroll'
 
 
 @benchmark.Enabled('android')
 class V8MobileInfiniteScroll(_InfiniteScrollBenchmark):
   """Measures V8 GC metrics and memory usage while scrolling the top mobile
   web pages.
   http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
 
   page_set = page_sets.MobileInfiniteScrollPageSet
 
   @classmethod
   def Name(cls):
     return 'v8.mobile_infinite_scroll'