Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1802243002: Should have sys.executable, or won't run on Windows. (Closed)

Created:
4 years, 9 months ago by Yoshisato Yanagisawa
Modified:
4 years, 9 months ago
Reviewers:
pgervais-g, pgervais
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, ukai
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Should have sys.executable, or won't run on Windows. BUG=594881 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M scripts/slave/goma_utils.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Yoshisato Yanagisawa
Hi, I just forgot to prepend sys.executable, and the command did not run on Windows. ...
4 years, 9 months ago (2016-03-15 04:53:11 UTC) #2
pgervais-g
On 2016/03/15 04:53:11, Yoshisato Yanagisawa wrote: > Hi, > > I just forgot to prepend ...
4 years, 9 months ago (2016-03-15 15:10:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802243002/1
4 years, 9 months ago (2016-03-16 01:01:36 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 01:08:10 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299306

Powered by Google App Engine
This is Rietveld 408576698