Amend PATH for nacl64 so loader can find x64 CRT

Amend PATH for nacl64 so loader can find x64 CRT

In order to keep from needing to system-install VS runtime DLLs
for debug builds, we put them in the output directory. This
mostly works, except in the case of nacl64 it requires the x64
CRT, but builds into the x86 output directory. The OS loader will
ignore the x86 ones, and continue searching the PATH, so before
launching nacl64.exe, append to PATH to the location of the x64
CRT DLLs.

See linked bug for more details and investigation.

R=cpu@chromium.org, mseaborn@chromium.org
BUG=346034
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253504

[cpu_(ooo_6.6-7.5), 2014-02-25 21:29:33]

lgtm

https://codereview.chromium.org/180223004/diff/20001/components/nacl/browser/...
File components/nacl/browser/nacl_process_host.cc (right):

https://codereview.chromium.org/180223004/diff/20001/components/nacl/browser/...
components/nacl/browser/nacl_process_host.cc:535: if
(old_path.find(x64_crt_path) == std::string::npos) {
if --> else if  ?

[scottmg, 2014-02-25 21:36:34]

https://codereview.chromium.org/180223004/diff/20001/components/nacl/browser/...
File components/nacl/browser/nacl_process_host.cc (right):

https://codereview.chromium.org/180223004/diff/20001/components/nacl/browser/...
components/nacl/browser/nacl_process_host.cc:535: if
(old_path.find(x64_crt_path) == std::string::npos) {
On 2014/02/25 21:29:34, cpu wrote:
> if --> else if  ?

Done.

[Mark Seaborn, 2014-02-26 02:24:50]

LGTM

https://codereview.chromium.org/180223004/diff/40001/components/nacl/browser/...
File components/nacl/browser/nacl_process_host.cc (right):

https://codereview.chromium.org/180223004/diff/40001/components/nacl/browser/...
components/nacl/browser/nacl_process_host.cc:535: } else if
(old_path.find(x64_crt_path) == std::string::npos) {
This is a bit icky because it matches any substring.  It would be cleaner to
split on ";" and check whether the list contains the exact path.

Alternatively, you could append the path unconditionally but have a global
variable indicating whether this initialisation has already been done, so that
PATH doesn't grow over time.

[scottmg, 2014-02-26 04:27:59]

https://codereview.chromium.org/180223004/diff/40001/components/nacl/browser/...
File components/nacl/browser/nacl_process_host.cc (right):

https://codereview.chromium.org/180223004/diff/40001/components/nacl/browser/...
components/nacl/browser/nacl_process_host.cc:535: } else if
(old_path.find(x64_crt_path) == std::string::npos) {
On 2014/02/26 02:24:50, Mark Seaborn wrote:
> This is a bit icky because it matches any substring.  It would be cleaner to
> split on ";" and check whether the list contains the exact path.

I admit I considered that when writing it and decided it was pretty unlikely,
but on the other hand, might as well do it properly. Done.

> 
> Alternatively, you could append the path unconditionally but have a global
> variable indicating whether this initialisation has already been done, so that
> PATH doesn't grow over time.

[Mark Seaborn, 2014-02-26 17:54:19]

LGTM

[scottmg, 2014-02-26 17:58:30]

Committed patchset #4 manually as r253504 (presubmit successful).