Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 180213005: Add layout test for the crash on infinite loop in SVG textPath. (Closed)

Created:
6 years, 9 months ago by ostap
Modified:
6 years, 9 months ago
Reviewers:
rwlbuis
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add a layout test for the crash on infinite loop in SVG textPath. The reported crash can't be reproduced anymore. BUG=232903 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168330

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed ids. #

Patch Set 3 : dumpAsText added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
LayoutTests/svg/text/svg-textpath-infinite-loop-crash-expected.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
ostap
6 years, 9 months ago (2014-02-28 17:05:28 UTC) #1
rwlbuis
Looks good but can be imporoved a bit. For the description I'd say: " Add ...
6 years, 9 months ago (2014-02-28 18:42:38 UTC) #2
ostap
https://codereview.chromium.org/180213005/diff/1/LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html File LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html (right): https://codereview.chromium.org/180213005/diff/1/LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html#newcode4 LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html:4: <div id="goal-line1">Test for infinite loop in textPath.</div> On 2014/02/28 ...
6 years, 9 months ago (2014-02-28 19:25:43 UTC) #3
rwlbuis
lgtm
6 years, 9 months ago (2014-02-28 19:56:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
6 years, 9 months ago (2014-02-28 19:56:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 21:23:06 UTC) #6
commit-bot: I haz the power
Retried try job too often on blink_android_compile_rel for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_android_compile_rel&number=1083
6 years, 9 months ago (2014-02-28 21:23:06 UTC) #7
ostap
The CQ bit was checked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-02-28 21:30:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
6 years, 9 months ago (2014-02-28 21:30:26 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 22:39:17 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20576
6 years, 9 months ago (2014-02-28 22:39:18 UTC) #11
ostap
The CQ bit was checked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-02-28 22:41:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
6 years, 9 months ago (2014-02-28 22:42:10 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 00:02:22 UTC) #14
commit-bot: I haz the power
Retried try job too often on blink_android_compile_dbg for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_android_compile_dbg&number=1075
6 years, 9 months ago (2014-03-01 00:02:22 UTC) #15
ostap
The CQ bit was checked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-03-01 04:10:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
6 years, 9 months ago (2014-03-01 04:10:25 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 05:22:43 UTC) #18
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20605
6 years, 9 months ago (2014-03-01 05:22:44 UTC) #19
ostap
The CQ bit was checked by sl.ostapenko@samsung.com
6 years, 9 months ago (2014-03-01 06:10:47 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
6 years, 9 months ago (2014-03-01 06:11:00 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 07:48:37 UTC) #22
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20613
6 years, 9 months ago (2014-03-01 07:48:38 UTC) #23
rwlbuis
On 2014/02/28 17:05:28, ostap wrote: Oops, I forgot something when reviewing this. You should either ...
6 years, 9 months ago (2014-03-01 12:40:27 UTC) #24
ostap
On 2014/03/01 12:40:27, rwlbuis wrote: > On 2014/02/28 17:05:28, ostap wrote: > > Oops, I ...
6 years, 9 months ago (2014-03-02 05:44:40 UTC) #25
rwlbuis
lgtm
6 years, 9 months ago (2014-03-03 12:47:03 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/40001
6 years, 9 months ago (2014-03-03 12:47:16 UTC) #27
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 21:09:10 UTC) #28
Message was sent while issue was closed.
Change committed as 168330

Powered by Google App Engine
This is Rietveld 408576698