|
|
DescriptionAdd a layout test for the crash on infinite loop in SVG textPath.
The reported crash can't be reproduced anymore.
BUG=232903
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168330
Patch Set 1 #
Total comments: 2
Patch Set 2 : Removed ids. #Patch Set 3 : dumpAsText added #
Messages
Total messages: 28 (0 generated)
Looks good but can be imporoved a bit. For the description I'd say: " Add a layout test for the crash on infinite loop in SVG textPath. The reported crash can't be reproduced anymore. BUG= " https://codereview.chromium.org/180213005/diff/1/LayoutTests/svg/text/svg-tex... File LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html (right): https://codereview.chromium.org/180213005/diff/1/LayoutTests/svg/text/svg-tex... LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html:4: <div id="goal-line1">Test for infinite loop in textPath.</div> You can remove id's if they are not useful. Basically these tests have to be minimal but still reproduce the problem.
https://codereview.chromium.org/180213005/diff/1/LayoutTests/svg/text/svg-tex... File LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html (right): https://codereview.chromium.org/180213005/diff/1/LayoutTests/svg/text/svg-tex... LayoutTests/svg/text/svg-textpath-infinite-loop-crash.html:4: <div id="goal-line1">Test for infinite loop in textPath.</div> On 2014/02/28 18:42:38, rwlbuis wrote: > You can remove id's if they are not useful. Basically these tests have to be > minimal but still reproduce the problem. Done.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on blink_android_compile_rel for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...
The CQ bit was checked by sl.ostapenko@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...
The CQ bit was checked by sl.ostapenko@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on blink_android_compile_dbg for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...
The CQ bit was checked by sl.ostapenko@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...
The CQ bit was checked by sl.ostapenko@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...
On 2014/02/28 17:05:28, ostap wrote: Oops, I forgot something when reviewing this. You should either make the test dumpAsText or add a reftest. The way it is now will likely generate pixel tests, which is maybe why it is failing.
On 2014/03/01 12:40:27, rwlbuis wrote: > On 2014/02/28 17:05:28, ostap wrote: > > Oops, I forgot something when reviewing this. You should either make the test > dumpAsText or add a reftest. The way it is now will likely generate pixel tests, > which is maybe why it is failing. Hm! Then why it works fine on my build and doesn't generate pixel test? In any case, I'll do ref test.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/180213005/40001
Message was sent while issue was closed.
Change committed as 168330 |