third_party/WebKit/Source/core/frame/FrameSerializer.cpp - Issue 1802123002: Unify Resource loading status tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameSerializer.cpp

Issue 1802123002: Unify Resource loading status tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameSerializer.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameSerializer.cpp b/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

index cdf2469adc597080decb393ed9728546a116ed78..0bd10178da2d529ca3af4447b2d8deafe2ca7ae5 100644

--- a/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameSerializer.cpp

@@ -412,7 +412,7 @@ void FrameSerializer::addImageToResources(ImageResource* image, const KURL& url)

void FrameSerializer::addFontToResources(FontResource* font)

{

- if (!font || !font->isLoaded() || !font->resourceBuffer() || !shouldAddURL(font->url()))

+ if (!font || font->isLoading() || !font->resourceBuffer() || !shouldAddURL(font->url()))

hiroshige 2016/03/18 23:21:20 What is the intention to this change? I feel |!fon

Nate Chapin 2016/03/21 22:04:01 This was a failed attempt at fixing some unit test

return;

RefPtr<SharedBuffer> data(font->resourceBuffer());