Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

Issue 1802123002: Unify Resource loading status tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
index ef415297270e868edf4484d758e17ec7b2116cd9..94966749b039fbf9da33907fcf0fa2aecc69adf4 100644
--- a/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/RawResourceTest.cpp
@@ -176,12 +176,12 @@ TEST(RawResourceTest, RevalidationSucceededForResourceWithoutBody)
TEST(RawResourceTest, AddClientDuringCallback)
{
RefPtrWillBeRawPtr<Resource> raw = RawResource::create(ResourceRequest("data:text/html,"), Resource::Raw);
- raw->setLoading(false);
// Create a non-null response.
ResourceResponse response = raw->response();
response.setURL(KURL(ParsedURLString, "http://600.613/"));
raw->setResponse(response);
+ raw->finish();
EXPECT_FALSE(raw->response().isNull());
OwnPtr<DummyClient> dummyClient = adoptPtr(new DummyClient());
@@ -215,12 +215,12 @@ private:
TEST(RawResourceTest, RemoveClientDuringCallback)
{
RefPtrWillBeRawPtr<Resource> raw = RawResource::create(ResourceRequest("data:text/html,"), Resource::Raw);
- raw->setLoading(false);
// Create a non-null response.
ResourceResponse response = raw->response();
response.setURL(KURL(ParsedURLString, "http://600.613/"));
raw->setResponse(response);
+ raw->finish();
EXPECT_FALSE(raw->response().isNull());
OwnPtr<DummyClient> dummyClient = adoptPtr(new DummyClient());

Powered by Google App Engine
This is Rietveld 408576698