Unify Resource loading status tracking

third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 158 matching lines @@
 
     resource->removeClient(client.get());
     EXPECT_FALSE(resource->hasClients());
     EXPECT_FALSE(client->called());
     EXPECT_EQ(0u, client->data().size());
 }
 
 TEST(RawResourceTest, AddClientDuringCallback)
 {
     RefPtrWillBeRawPtr<Resource> raw = RawResource::create(ResourceRequest("data:text/html,"), Resource::Raw);
-    raw->setLoading(false);
 
     // Create a non-null response.
     ResourceResponse response = raw->response();
     response.setURL(KURL(ParsedURLString, "http://600.613/"));
     raw->setResponse(response);

[hiroshige, 2016/03/18 23:21:20]

How about calling raw->finish() for consistency?

[Nate Chapin, 2016/03/21 22:04:01]

Done.

     EXPECT_FALSE(raw->response().isNull());
 
     OwnPtr<DummyClient> dummyClient = adoptPtr(new DummyClient());
     OwnPtr<AddingClient> addingClient = adoptPtr(new AddingClient(dummyClient.get(), raw.get()));
     raw->addClient(addingClient.get());
     testing::runPendingTasks();
     raw->removeClient(addingClient.get());
     EXPECT_FALSE(dummyClient->called());
     EXPECT_FALSE(raw->hasClients());
 }
@@ skipping 13 matching lines @@
         resource->removeClient(this);
     }
     String debugName() const override { return "RemovingClient"; }
 private:
     DummyClient* m_dummyClient;
 };
 
 TEST(RawResourceTest, RemoveClientDuringCallback)
 {
     RefPtrWillBeRawPtr<Resource> raw = RawResource::create(ResourceRequest("data:text/html,"), Resource::Raw);
-    raw->setLoading(false);
 
     // Create a non-null response.
     ResourceResponse response = raw->response();
     response.setURL(KURL(ParsedURLString, "http://600.613/"));
     raw->setResponse(response);
+    raw->finish();
     EXPECT_FALSE(raw->response().isNull());
 
     OwnPtr<DummyClient> dummyClient = adoptPtr(new DummyClient());
     OwnPtr<RemovingClient> removingClient = adoptPtr(new RemovingClient(dummyClient.get()));
     raw->addClient(dummyClient.get());
     raw->addClient(removingClient.get());
     testing::runPendingTasks();
     EXPECT_FALSE(raw->hasClients());
 }
 
 } // namespace blink