chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc - Issue 1802073002: Makes vertical alignment of location bar bubbles same

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 1802073002: Makes vertical alignment of location bar bubbles same (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc » ('j') | chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

index c9e0292c21a0376aae8330a8c73ca0bfc92b37df..285b09cbd872f6c9900a5b781c54f8750f41d132 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

@@ -274,7 +274,9 @@ BookmarkBubbleView::BookmarkBubbleView(

remove_bookmark_(false),

apply_edits_(true) {

// Compensate for built-in vertical padding in the anchor view's image.

- set_anchor_view_insets(gfx::Insets(2, 0, 2, 0));

+ // This is different from 5 pixel inset that is used in other cases because

+ // this bubble is using NONE as the arrow type.

+ set_anchor_view_insets(gfx::Insets(-1, 0, -1, 0));

Evan Stade 2016/03/14 21:57:53 nit: gfx::Insets(-1, 0) can you colocate this wit

varkha 2016/03/14 22:13:06 Done.

}

base::string16 BookmarkBubbleView::GetTitle() {