Makes vertical alignment of location bar bubbles same

chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
 
 #include <utility>
 
 #include "base/macros.h"
 #include "base/strings/string16.h"
@@ skipping 66 matching lines @@
   if (bookmark_bubble_)
     return nullptr;
 
   bookmark_bubble_ =
       new BookmarkBubbleView(anchor_view, observer, std::move(delegate),
                              profile, url, !already_bookmarked);
   if (!anchor_view) {
     bookmark_bubble_->SetAnchorRect(anchor_rect);
     bookmark_bubble_->set_parent_window(parent_window);
   }
+  // Compensate for built-in vertical padding in the anchor view's image.
+  // This is different from 5 pixel inset that is used in other cases because
+  // this bubble is using NONE as the arrow type.
+  bookmark_bubble_->set_anchor_view_insets(gfx::Insets(-1, 0));

[Peter Kasting, 2016/03/14 22:35:51]

Do you still need to do this if you use PAINT_TRANSPARENT for the arrow type
instead?  I think that should position the bubble like the others but just not
draw an arrow.

[varkha, 2016/03/15 00:11:42]

That would indeed be great and I wanted to do that. However with the arrow code
as it is the transparent arrow is not transparent to clicks so it will be a
noticeable regression in how easy it is to click the star when a bubble is open
(assuming the same visible vertical offset).
I will look into whether it is possible to update hit testing for the bubble to
account for a transparent arrow but prefer to do that separately.

[Evan Stade, 2016/03/15 00:13:27]

I think it should be possible and it's probably a decent idea to look into that
before landing this patch since it has the potential to affect this patch.

[Peter Kasting, 2016/03/15 00:34:15]

Yeah, I'd like to see if this is easy enough to do as well.  Doing it separately
is fine but I would go ahead and look at that first.

[varkha, 2016/03/16 03:45:30]

I have tried to pursue this. I can make the BubbleFrameView transparent to
events by overriding DoesIntersectRect (similar to [1]) but that doesn't solve
the problem because the bubble has its own native widget and so the mouse events
never reach the browser frame's root view. Am I missing something easy?
[1] -
https://codereview.chromium.org/1767363002/diff/80001/chrome/browser/ui/views...

   views::Widget* bubble_widget =
       views::BubbleDialogDelegateView::CreateBubble(bookmark_bubble_);
   bubble_widget->Show();
   // Select the entire title textfield contents when the bubble is first shown.
   bookmark_bubble_->title_tf_->SelectAll(true);
   bookmark_bubble_->SetArrowPaintType(views::BubbleBorder::PAINT_NONE);
 
   if (bookmark_bubble_->observer_) {
     BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);
     const BookmarkNode* node = model->GetMostRecentlyAddedUserNodeForURL(url);
@@ skipping 169 matching lines @@
       parent_model_(BookmarkModelFactory::GetForProfile(profile_),
                     BookmarkModelFactory::GetForProfile(profile_)
                         ->GetMostRecentlyAddedUserNodeForURL(url)),
       remove_button_(NULL),
       edit_button_(NULL),
       close_button_(NULL),
       title_tf_(NULL),
       parent_combobox_(NULL),
       remove_bookmark_(false),
       apply_edits_(true) {
-  // Compensate for built-in vertical padding in the anchor view's image.
-  set_anchor_view_insets(gfx::Insets(2, 0, 2, 0));
 }
 
 base::string16 BookmarkBubbleView::GetTitle() {
   BookmarkModel* bookmark_model =
       BookmarkModelFactory::GetForProfile(profile_);
   const BookmarkNode* node =
       bookmark_model->GetMostRecentlyAddedUserNodeForURL(url_);
   if (node)
     return node->GetTitle();
   else
@@ skipping 64 matching lines @@
   if (node) {
     const base::string16 new_title = title_tf_->text();
     if (new_title != node->GetTitle()) {
       model->SetTitle(node, new_title);
       content::RecordAction(
           UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"));
     }
     parent_model_.MaybeChangeParent(node, parent_combobox_->selected_index());
   }
 }