Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1802013003: MD History: Refactor how data is created in tests (Closed)

Created:
4 years, 9 months ago by tsergeant
Modified:
4 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Refactor how data is created in tests This CL adds a helper method, createHistoryEntry, which creates a mock history visit from a timestamp and URL. This makes creating test data simpler and more consistent. Adapted from https://codereview.chromium.org/1648803003/ by hsampson@google.com BUG=425625 Committed: https://crrev.com/7c11c1644b84f70c1e5a665dd4296f544b9d1700 Cr-Commit-Position: refs/heads/master@{#381413}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Update param type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -82 lines) Patch
M chrome/test/data/webui/md_history/history_item_test.js View 1 3 chunks +18 lines, -15 lines 0 comments Download
M chrome/test/data/webui/md_history/history_list_test.js View 1 6 chunks +26 lines, -50 lines 0 comments Download
M chrome/test/data/webui/md_history/history_supervised_user_test.js View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/test/data/webui/md_history/history_toolbar_test.js View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/test/data/webui/md_history/test_util.js View 1 2 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tsergeant
I pulled out the test refactor into a separate CL, PTAl
4 years, 9 months ago (2016-03-16 03:02:32 UTC) #2
calamity
lgtm https://codereview.chromium.org/1802013003/diff/20001/chrome/test/data/webui/md_history/test_util.js File chrome/test/data/webui/md_history/test_util.js (right): https://codereview.chromium.org/1802013003/diff/20001/chrome/test/data/webui/md_history/test_util.js#newcode45 chrome/test/data/webui/md_history/test_util.js:45: * @param {number} timestamp Timestamp of the entry, ...
4 years, 9 months ago (2016-03-16 05:42:48 UTC) #3
tsergeant
https://codereview.chromium.org/1802013003/diff/20001/chrome/test/data/webui/md_history/test_util.js File chrome/test/data/webui/md_history/test_util.js (right): https://codereview.chromium.org/1802013003/diff/20001/chrome/test/data/webui/md_history/test_util.js#newcode45 chrome/test/data/webui/md_history/test_util.js:45: * @param {number} timestamp Timestamp of the entry, in ...
4 years, 9 months ago (2016-03-16 05:46:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1802013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1802013003/40001
4 years, 9 months ago (2016-03-16 05:47:07 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-16 07:01:56 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 07:03:12 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7c11c1644b84f70c1e5a665dd4296f544b9d1700
Cr-Commit-Position: refs/heads/master@{#381413}

Powered by Google App Engine
This is Rietveld 408576698