Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801973002: Move fx_crypto.h and fpdf_text.h out of core/include. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move fx_crypto.h and fpdf_text.h out of core/include. This CL moves the two files and breaks fpdf_text.h apart into individual pieces. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/13ee55a8267963c9b39486a6a22646fbdd770742

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -273 lines) Patch
M BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M core/fdrm/crypto/fx_crypt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fdrm/crypto/fx_crypt_aes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fdrm/crypto/fx_crypt_sha.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fdrm/crypto/include/fx_crypt.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_standard_crypto_handler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdftext/fpdf_text_int.cpp View 3 chunks +15 lines, -4 lines 0 comments Download
A core/fpdftext/include/ipdf_linkextract.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + core/fpdftext/include/ipdf_textpage.h View 3 chunks +6 lines, -58 lines 0 comments Download
A core/fpdftext/include/ipdf_textpagefind.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
M core/fpdftext/text_int.h View 1 chunk +3 lines, -1 line 0 comments Download
D core/include/fdrm/fx_crypt.h View 1 chunk +0 lines, -71 lines 0 comments Download
D core/include/fpdftext/fpdf_text.h View 1 chunk +0 lines, -121 lines 0 comments Download
M core/include/fxcrt/fx_coordinates.h View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fpdf_searchex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/javascript/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 2 chunks +4 lines, -2 lines 0 comments Download
A xfa/fxfa/app/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL. https://codereview.chromium.org/1801973002/diff/1/core/fpdftext/fpdf_text_int.cpp File core/fpdftext/fpdf_text_int.cpp (right): https://codereview.chromium.org/1801973002/diff/1/core/fpdftext/fpdf_text_int.cpp#newcode1912 core/fpdftext/fpdf_text_int.cpp:1912: if (info.m_Flag == FPDFTEXT_CHAR_NORMAL || The CHAR_ versions ...
4 years, 9 months ago (2016-03-14 19:48:04 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-14 19:54:22 UTC) #3
dsinclair
4 years, 9 months ago (2016-03-14 19:56:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:2) manually as
13ee55a8267963c9b39486a6a22646fbdd770742 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698