components/leveldb/leveldb_app.h - Issue 1801963002: Change primordial pipes to ShellClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/leveldb/leveldb_app.h

Issue 1801963002: Change primordial pipes to ShellClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/leveldb/leveldb_app.h

diff --git a/components/leveldb/leveldb_app.h b/components/leveldb/leveldb_app.h

index 4b87fc897df145ba74ce60ee5433909d0823f10b..a2e806fdd1e0f628f0a74e81632557ec423bcf4f 100644

--- a/components/leveldb/leveldb_app.h

+++ b/components/leveldb/leveldb_app.h

@@ -25,9 +25,7 @@ class LevelDBApp : public mojo::ShellClient,

const mojo::Identity& identity,

uint32_t id) override;

bool AcceptConnection(mojo::Connection* connection) override;

- // TODO(erg): What do we have to do on shell error?

- // bool OnShellConnectionError() override;

+ void ShellConnectionLost() override;

// |InterfaceFactory<LevelDBService>| implementation:

void Create(mojo::Connection* connection,