Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1801953003: Update chrome_elf_unittests imports list for VS 2015 (Closed)

Created:
4 years, 9 months ago by brucedawson
Modified:
4 years, 9 months ago
Reviewers:
robertshield
CC:
chromium-reviews, tfarina, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update chrome_elf_unittests imports list for VS 2015 VS 2015 component builds import more DLLs so chrome_elf_unittests needs updating to reflect that. This change also tightens the restrictions on the import list - the CRT DLLs should only be needed in component builds. BUG=440500, 594360 Committed: https://crrev.com/8b3670491a67a5ab16a3df58bfda60f0fb42afa2 Cr-Commit-Position: refs/heads/master@{#381145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome_elf/elf_imports_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
brucedawson
PTAL. Simple tweak to fix a test that fails with VS 2015. Any concerns with ...
4 years, 9 months ago (2016-03-14 21:38:09 UTC) #3
robertshield
No concerns, this looks great and the CRT dll exclusion is definitely more correct this ...
4 years, 9 months ago (2016-03-15 01:13:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801953003/1
4 years, 9 months ago (2016-03-15 01:19:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 01:24:51 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 01:25:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b3670491a67a5ab16a3df58bfda60f0fb42afa2
Cr-Commit-Position: refs/heads/master@{#381145}

Powered by Google App Engine
This is Rietveld 408576698