Issue 1801943002: [Cronet] Fix race in UploadDataStream.attachToRequest.

Issue 1801943002: [Cronet] Fix race in UploadDataStream.attachToRequest. (Closed)

Created:
4 years, 9 months ago by mef

Modified:
4 years, 9 months ago

Reviewers:
xunjieli

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[Cronet] Fix race in UploadDataStream.attachToRequest. - Add UploadDataStream.initalizeWithRequest to call DataProvider.getLength() outside of lock. - Use AttachNativeAdapterToRequest in UrlRequest.startInternal under the lock to ensure that request is not canceled. BUG=593490 Review URL: https://codereview.chromium.org/1777333002 Cr-Commit-Position: refs/heads/master@{#380654} (cherry picked from commit db433eabe1d4854125e00885fbba073ada75ad94) R=xunjieli@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9db0b53eb57adab8b47b746b5c1cd5477c24422f

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -34 lines)			Patch
M	components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java	View	3 chunks	+33 lines, -31 lines	0 comments	Download
M	components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java	View	3 chunks	+69 lines, -0 lines	0 comments	Download
M	components/cronet/tools/cr_cronet.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

mef

Hi Helen, PTAL, This CL merges UploadDataStream.attachToRequest fix into M50. thanks, -m

4 years, 9 months ago (2016-03-14 19:15:16 UTC) #2

mef

4 years, 9 months ago (2016-03-14 19:45:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9db0b53eb57adab8b47b746b5c1cd5477c24422f (presubmit successful).