Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801923002: Add missing DEPS files; enable checkdeps. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing DEPS files; enable checkdeps. This CL adds the needed DEPS files to make checkdeps pass correctly. The checkdeps PRESUBMIT method has been copied from Chromium and is enabled on CL upload. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/544bbc6d81ee9d94a09809830b3f622f2dbad28a

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +57 lines, -0 lines 0 comments Download
A core/fxge/freetype/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A fpdfsdk/javascript/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A xfa/fgas/font/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A xfa/fxjse/DEPS View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL. Making deps clean will make it easier to get all the right deps entries ...
4 years, 9 months ago (2016-03-14 18:53:46 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1801923002/diff/1/xfa/fxjse/DEPS File xfa/fxjse/DEPS (right): https://codereview.chromium.org/1801923002/diff/1/xfa/fxjse/DEPS#newcode2 xfa/fxjse/DEPS:2: '+fpdfsdk/include/jsapi', XFA including fpdfsk is a layering violation, ...
4 years, 9 months ago (2016-03-14 19:05:27 UTC) #3
dsinclair
Committed patchset #2 (id:20001) manually as 544bbc6d81ee9d94a09809830b3f622f2dbad28a (presubmit successful).
4 years, 9 months ago (2016-03-14 19:07:44 UTC) #5
dsinclair
4 years, 9 months ago (2016-03-14 19:08:01 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1801923002/diff/1/xfa/fxjse/DEPS
File xfa/fxjse/DEPS (right):

https://codereview.chromium.org/1801923002/diff/1/xfa/fxjse/DEPS#newcode2
xfa/fxjse/DEPS:2: '+fpdfsdk/include/jsapi',
On 2016/03/14 19:05:27, Tom Sepez wrote:
> XFA including fpdfsk is a layering violation, but let's leave it for now.
Maybe
> comment this?

Done.

Powered by Google App Engine
This is Rietveld 408576698