Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1801893003: Add a variable indicating the target as Android M or later. (Closed)

Created:
4 years, 9 months ago by mnaganov (inactive)
Modified:
4 years, 9 months ago
Reviewers:
agrieve, Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a variable indicating the target as Android M or later. The system linker in Android M and later unpacks packed relocations directly. This means that we can unconditionally enable relocation packing for any APK that is explicitly designed to only run on such Android releases, irrespective of whether or not the chromium or other customized linker is used. Invoker indicates this by setting requires_sdk_api_level_23 to true. BUG=579610 Committed: https://crrev.com/18d74636c85eb974ef00883f54cb06381ea123f6 Cr-Commit-Position: refs/heads/master@{#381246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M build/config/android/rules.gni View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mnaganov (inactive)
Cloned from https://codereview.chromium.org/1696803002/ and updated to address your comment.
4 years, 9 months ago (2016-03-15 00:03:50 UTC) #2
Torne
lgtm
4 years, 9 months ago (2016-03-15 12:07:06 UTC) #4
mnaganov (inactive)
Andrew, please approve!
4 years, 9 months ago (2016-03-15 16:26:21 UTC) #6
agrieve
On 2016/03/15 16:26:21, mnaganov wrote: > Andrew, please approve! lgtm!
4 years, 9 months ago (2016-03-15 16:53:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801893003/1
4 years, 9 months ago (2016-03-15 16:55:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 17:43:59 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 17:45:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18d74636c85eb974ef00883f54cb06381ea123f6
Cr-Commit-Position: refs/heads/master@{#381246}

Powered by Google App Engine
This is Rietveld 408576698