Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: pkg/analysis_server/lib/src/plugin/server_plugin.dart

Issue 1801883002: Remove old index and search implementations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/plugin/server_plugin.dart
diff --git a/pkg/analysis_server/lib/src/plugin/server_plugin.dart b/pkg/analysis_server/lib/src/plugin/server_plugin.dart
index b35d5bd546bc149b7013f42b636a8891805905a8..91ecb32d2b5ce8ebaa2433d92b06ce3e495e5745 100644
--- a/pkg/analysis_server/lib/src/plugin/server_plugin.dart
+++ b/pkg/analysis_server/lib/src/plugin/server_plugin.dart
@@ -25,12 +25,9 @@ import 'package:analysis_server/src/domains/analysis/navigation_dart.dart';
import 'package:analysis_server/src/domains/analysis/occurrences_dart.dart';
import 'package:analysis_server/src/edit/edit_domain.dart';
import 'package:analysis_server/src/provisional/completion/completion_core.dart';
-import 'package:analysis_server/src/provisional/index/index.dart';
-import 'package:analysis_server/src/provisional/index/index_core.dart';
import 'package:analysis_server/src/search/search_domain.dart';
import 'package:analysis_server/src/services/correction/assist_internal.dart';
import 'package:analysis_server/src/services/correction/fix_internal.dart';
-import 'package:analysis_server/src/services/index/index_contributor.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:plugin/plugin.dart';
@@ -138,11 +135,6 @@ class ServerPlugin implements Plugin {
ExtensionPoint fixContributorExtensionPoint;
/**
- * The extension point that allows plugins to register index contributors.
- */
- ExtensionPoint indexContributorExtensionPoint;
Brian Wilkerson 2016/03/14 18:57:32 Why are we getting rid of this? I thought we had p
scheglov 2016/03/14 19:18:38 AFAIK we don't have such plugins yet. It was wor
-
- /**
* The extension point that allows plugins to register navigation
* contributors.
*/
@@ -200,13 +192,6 @@ class ServerPlugin implements Plugin {
fixContributorExtensionPoint.extensions;
/**
- * Return a list containing all of the index contributors that were
- * contributed.
- */
- List<IndexContributor> get indexContributors =>
- indexContributorExtensionPoint.extensions;
-
- /**
* Return a list containing all of the navigation contributors that were
* contributed.
*/
@@ -261,8 +246,6 @@ class ServerPlugin implements Plugin {
DOMAIN_EXTENSION_POINT, _validateDomainExtension);
fixContributorExtensionPoint = registerExtensionPoint(
FIX_CONTRIBUTOR_EXTENSION_POINT, _validateFixContributorExtension);
- indexContributorExtensionPoint = registerExtensionPoint(
- INDEX_CONTRIBUTOR_EXTENSION_POINT, _validateIndexContributorExtension);
navigationContributorExtensionPoint = registerExtensionPoint(
NAVIGATION_CONTRIBUTOR_EXTENSION_POINT,
_validateNavigationContributorExtension);
@@ -323,11 +306,6 @@ class ServerPlugin implements Plugin {
//
registerExtension(
FIX_CONTRIBUTOR_EXTENSION_POINT_ID, new DefaultFixContributor());
- //
- // Register index contributors.
- //
- registerExtension(
- INDEX_CONTRIBUTOR_EXTENSION_POINT_ID, new DartIndexContributor());
}
/**
@@ -403,17 +381,6 @@ class ServerPlugin implements Plugin {
/**
* Validate the given extension by throwing an [ExtensionError] if it is not a
- * valid index contributor.
- */
- void _validateIndexContributorExtension(Object extension) {
- if (extension is! IndexContributor) {
- String id = indexContributorExtensionPoint.uniqueIdentifier;
- throw new ExtensionError('Extensions to $id must be an IndexContributor');
- }
- }
-
- /**
- * Validate the given extension by throwing an [ExtensionError] if it is not a
* valid navigation contributor.
*/
void _validateNavigationContributorExtension(Object extension) {

Powered by Google App Engine
This is Rietveld 408576698