Remove old index and search implementations.

Remove old index and search implementations.

Also rename the new implementation files and classes to remove the
'2' suffix.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/bd76934452e5fcda0031bcebd65c35f08888da85

[Brian Wilkerson, 2016-03-14 18:57:33]

LGTM

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/server_plugin.dart (left):

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/server_plugin.dart:143: ExtensionPoint
indexContributorExtensionPoint;
Why are we getting rid of this? I thought we had plugins that needed this
functionality.

If we don't have plugins that need it, can we restore it later if we need to, or
does the new architecture preclude allowing contributions?

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
(right):

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/search/search_engine_internal.dart:5:
library services.src.search.search_engine2;
nit: I was going to suggest dropping the "2", but the whole library name is
wrong. It really ought to be
"analysis_server.src.services.search.search_engine_internal", or we should drop
the library directive altogether.

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/search/element_references_test.dart (right):

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/search/element_references_test.dart:236: //   
expect(searchElement.kind, ElementKind.FILE);
Remove this?

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/search/search_engine_test.dart (right):

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/search/search_engine_test.dart:5: library
test.services.src.search.search_engine2;
"analysis_server.test.services.search.search_engine_test"?

[scheglov, 2016-03-14 19:18:38]

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/server_plugin.dart (left):

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/server_plugin.dart:143: ExtensionPoint
indexContributorExtensionPoint;
On 2016/03/14 18:57:32, Brian Wilkerson wrote:
> Why are we getting rid of this? I thought we had plugins that needed this
> functionality.

  AFAIK we don't have such plugins yet.
  It was work in progress to support Angular2 plugins, but at the end it has
never been implemented.


> If we don't have plugins that need it, can we restore it later if we need to,
or
> does the new architecture preclude allowing contributions?

We will able to restore it later.
_ContextIndex can be taught to index other kinds of objects than
CompilationUnits and provide references to Dart elements in these objects.

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/search/search_engine_internal.dart
(right):

https://codereview.chromium.org/1801883002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/search/search_engine_internal.dart:5:
library services.src.search.search_engine2;
On 2016/03/14 18:57:32, Brian Wilkerson wrote:
> nit: I was going to suggest dropping the "2", but the whole library name is
> wrong. It really ought to be
> "analysis_server.src.services.search.search_engine_internal", or we should
drop
> the library directive altogether.

Done.

[scheglov, 2016-03-14 19:19:46]

Description was changed from

==========
Remove old index and search implementations.

Also rename the new implementation files and classes to remove the
'2' suffix.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Remove old index and search implementations.

Also rename the new implementation files and classes to remove the
'2' suffix.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/bd76934452e5fcda0031bcebd65c35f08888da85
==========

[scheglov, 2016-03-14 19:19:47]

Committed patchset #1 (id:1) manually as
bd76934452e5fcda0031bcebd65c35f08888da85 (presubmit successful).