Transfer LayerImpl ownership to LayerTreeImpl

Transfer LayerImpl ownership to LayerTreeImpl

I have taken a very simple strategy. I have
retained all LayerImpl functions related to
transfer of ownership (AddChild, etc). These now
update raw pointers on the LayerImpl as well as
updating true ownership by talking to the LTI.

This allows most unit test code to remain as is.
LayerImpl's may be constructed and ownership may
be transferred just as it had been.

BUG=594026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/83fbfc832bb24abbea9c9dfa4ff17ad20bc047f4
Cr-Commit-Position: refs/heads/master@{#382619}

[Ian Vollick, 2016-03-14 17:53:19]

Description was changed from

==========
WIP - transfer LayerImpl ownership to LayerTreeImpl

BUG=
==========

to

==========
WIP - transfer LayerImpl ownership to LayerTreeImpl

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Ian Vollick, 2016-03-18 18:11:26]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 18:11:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/40001

[commit-bot: I haz the power, 2016-03-18 18:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 18:14:53]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Ian Vollick, 2016-03-18 18:15:28]

Description was changed from

==========
WIP - transfer LayerImpl ownership to LayerTreeImpl

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Transfer LayerImpl ownership to LayerTreeImpl

I have taken a very simple strategy. I have
retained all LayerImpl functions related to
transfer of ownership (AddChild, etc). These now
update raw pointers on the LayerImpl as well as
updating true ownership by talking to the LTI.

This allows most unit test code to remain as is.
LayerImpl's may be constructed and ownership may
be transferred just as it had been.

BUG=594026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Ian Vollick, 2016-03-18 18:15:28]

vollick@chromium.org changed reviewers:
+ ajuma@chromium.org

[Ian Vollick, 2016-03-18 19:22:17]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 19:22:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/60001

[commit-bot: I haz the power, 2016-03-18 19:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 19:39:59]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[ajuma, 2016-03-18 22:09:21]

The strategy taken here looks great.

https://codereview.chromium.org/1801853002/diff/60001/cc/layers/layer_collect...
File cc/layers/layer_collections.h (right):

https://codereview.chromium.org/1801853002/diff/60001/cc/layers/layer_collect...
cc/layers/layer_collections.h:1: // Copyright 2013 The Chromium Authors. All
rights reserved.
It's 2016 :)

https://codereview.chromium.org/1801853002/diff/60001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest_animation_timelines.cc (left):

https://codereview.chromium.org/1801853002/diff/60001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_animation_timelines.cc:62: // Makes sure that
SetNeedsAnimate does not cause the CommitRequested() state to
The changes in this file seem mostly unrelated to this CL. Rebasing weirdness?

https://codereview.chromium.org/1801853002/diff/60001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/1801853002/diff/60001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:1044: root_layer_ = nullptr;
When does the root layer need to get cleared this way (instead of by a call to
SetRootLayer(nullptr))?

[Ian Vollick, 2016-03-19 02:31:35]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-19 02:31:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/80001

[Ian Vollick, 2016-03-19 03:05:04]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-19 03:05:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/100001

[Ian Vollick, 2016-03-19 03:05:23]

https://codereview.chromium.org/1801853002/diff/60001/cc/layers/layer_collect...
File cc/layers/layer_collections.h (right):

https://codereview.chromium.org/1801853002/diff/60001/cc/layers/layer_collect...
cc/layers/layer_collections.h:1: // Copyright 2013 The Chromium Authors. All
rights reserved.
On 2016/03/18 22:09:21, ajuma wrote:
> It's 2016 :)

(Checks watch). Good point, updated.

https://codereview.chromium.org/1801853002/diff/60001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest_animation_timelines.cc (left):

https://codereview.chromium.org/1801853002/diff/60001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_animation_timelines.cc:62: // Makes sure that
SetNeedsAnimate does not cause the CommitRequested() state to
On 2016/03/18 22:09:21, ajuma wrote:
> The changes in this file seem mostly unrelated to this CL. Rebasing weirdness?

Yep, definitely rebasing weirdness. Shouldn't have been in the CL at all.

https://codereview.chromium.org/1801853002/diff/60001/cc/trees/layer_tree_imp...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/1801853002/diff/60001/cc/trees/layer_tree_imp...
cc/trees/layer_tree_impl.cc:1044: root_layer_ = nullptr;
On 2016/03/18 22:09:21, ajuma wrote:
> When does the root layer need to get cleared this way (instead of by a call to
> SetRootLayer(nullptr))?

Turns out never. Removed.

[commit-bot: I haz the power, 2016-03-19 03:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 03:45:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ian Vollick, 2016-03-19 04:23:42]

On 2016/03/19 03:45:08, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Hrm. Test failures are real. Please ignore for now.

[Ian Vollick, 2016-03-21 14:27:08]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 14:27:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/120001

[Ian Vollick, 2016-03-21 15:01:49]

https://codereview.chromium.org/1801853002/diff/120001/cc/trees/tree_synchron...
File cc/trees/tree_synchronizer.cc (right):

https://codereview.chromium.org/1801853002/diff/120001/cc/trees/tree_synchron...
cc/trees/tree_synchronizer.cc:81: layer_impl->children().clear();
The issue here was that ClearChildList had ownership implications causing nodes
in the in-progress tree to be deleted.

[ajuma, 2016-03-21 15:09:51]

Thanks, lgtm

[commit-bot: I haz the power, 2016-03-21 15:31:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 15:31:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ian Vollick, 2016-03-21 18:08:15]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 18:08:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/140001

[Ian Vollick, 2016-03-21 19:01:42]

vollick@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Ian Vollick, 2016-03-21 19:02:01]

On 2016/03/21 18:08:47, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1801853002/140001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1801853002/140001

+yfriedman for content/browser/android/compositor/*

[commit-bot: I haz the power, 2016-03-21 20:00:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:00:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yaron, 2016-03-22 02:51:19]

lgtm

[Ian Vollick, 2016-03-22 14:26:52]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 14:27:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/160001

[commit-bot: I haz the power, 2016-03-22 16:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 16:25:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ian Vollick, 2016-03-22 17:01:00]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 17:01:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/180001

[commit-bot: I haz the power, 2016-03-22 18:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 18:09:25]

Dry run: This issue passed the CQ dry run.

[Ian Vollick, 2016-03-22 18:25:28]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2016-03-22 18:25:28]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org,
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1801853002/#ps180001
(title: "more asan.")

[commit-bot: I haz the power, 2016-03-22 18:26:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801853002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801853002/180001

[commit-bot: I haz the power, 2016-03-22 18:33:36]

Description was changed from

==========
Transfer LayerImpl ownership to LayerTreeImpl

I have taken a very simple strategy. I have
retained all LayerImpl functions related to
transfer of ownership (AddChild, etc). These now
update raw pointers on the LayerImpl as well as
updating true ownership by talking to the LTI.

This allows most unit test code to remain as is.
LayerImpl's may be constructed and ownership may
be transferred just as it had been.

BUG=594026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Transfer LayerImpl ownership to LayerTreeImpl

I have taken a very simple strategy. I have
retained all LayerImpl functions related to
transfer of ownership (AddChild, etc). These now
update raw pointers on the LayerImpl as well as
updating true ownership by talking to the LTI.

This allows most unit test code to remain as is.
LayerImpl's may be constructed and ownership may
be transferred just as it had been.

BUG=594026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-22 18:33:38]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-03-22 18:35:38]

Description was changed from

==========
Transfer LayerImpl ownership to LayerTreeImpl

I have taken a very simple strategy. I have
retained all LayerImpl functions related to
transfer of ownership (AddChild, etc). These now
update raw pointers on the LayerImpl as well as
updating true ownership by talking to the LTI.

This allows most unit test code to remain as is.
LayerImpl's may be constructed and ownership may
be transferred just as it had been.

BUG=594026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Transfer LayerImpl ownership to LayerTreeImpl

I have taken a very simple strategy. I have
retained all LayerImpl functions related to
transfer of ownership (AddChild, etc). These now
update raw pointers on the LayerImpl as well as
updating true ownership by talking to the LTI.

This allows most unit test code to remain as is.
LayerImpl's may be constructed and ownership may
be transferred just as it had been.

BUG=594026
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/83fbfc832bb24abbea9c9dfa4ff17ad20bc047f4
Cr-Commit-Position: refs/heads/master@{#382619}
==========

[commit-bot: I haz the power, 2016-03-22 18:35:40]

Patchset 10 (id:??) landed as
https://crrev.com/83fbfc832bb24abbea9c9dfa4ff17ad20bc047f4
Cr-Commit-Position: refs/heads/master@{#382619}