Update iOS GN templates.

Update iOS GN templates.

The test template was forwarding output_name and output_extension to the ios_app template, but that isn't used by the ios_app template. If somebody actually uses this value, they'll get an error, so it's better to not pretend to support it.

The test template also forwarded visibility which was never used by ios_app. This should be used so is now hooked up to the group generated by ios_app.

Committed: https://crrev.com/71f8ea104d391816e5ca040534dcc3b288b0a59b
Cr-Commit-Position: refs/heads/master@{#381057}

[brettw, 2016-03-14 17:27:16]

Description was changed from

==========
Update iOS GN templates.

The test template was forwarding output_extension to the ios_app template, but
that isn't used by the ios_app template. If somebody actually uses this value,
they'll get an error, so it's better to not pretend to support it.

The test template also forwarded visibility which was never used by ios_app.
This should be used so is now hooked up to the group generated by ios_app.
==========

to

==========
Update iOS GN templates.

The test template was forwarding output_name and output_extension to the ios_app
template, but that isn't used by the ios_app template. If somebody actually uses
this value, they'll get an error, so it's better to not pretend to support it.

The test template also forwarded visibility which was never used by ios_app.
This should be used so is now hooked up to the group generated by ios_app.
==========

[brettw, 2016-03-14 17:27:16]

brettw@chromium.org changed reviewers:
+ sdefresne@chromium.org

[brettw, 2016-03-14 17:28:50]

I'm actually feeling like we should rename app_name in the iOS template to be
output_name. This will allow people to set the name of the final output on a
target without regard to what type of target it is. I can do this in a followup
if you agree.

[brettw, 2016-03-14 17:28:53]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-14 17:29:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801833002/1

[commit-bot: I haz the power, 2016-03-14 18:10:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 18:10:06]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2016-03-14 19:49:47]

On 2016/03/14 18:10:06, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Friendly ping, sdefresne@. This issue blocks me from landing
https://codereview.chromium.org/1751563002/, which quite some blink people are
waiting for. :) Thanks!

[brettw, 2016-03-14 20:06:59]

brettw@chromium.org changed reviewers:
+ yzshen@chromium.org

[brettw, 2016-03-14 20:07:00]

-> yzshen

sdefresne can comment TBR and we can address any additional suggestions in a
non-blocking fashion.

[yzshen1, 2016-03-14 20:12:43]

lgtm


Thanks, Brett!

[brettw, 2016-03-14 20:13:14]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-03-14 20:13:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801833002/1

[commit-bot: I haz the power, 2016-03-14 20:19:31]

Description was changed from

==========
Update iOS GN templates.

The test template was forwarding output_name and output_extension to the ios_app
template, but that isn't used by the ios_app template. If somebody actually uses
this value, they'll get an error, so it's better to not pretend to support it.

The test template also forwarded visibility which was never used by ios_app.
This should be used so is now hooked up to the group generated by ios_app.
==========

to

==========
Update iOS GN templates.

The test template was forwarding output_name and output_extension to the ios_app
template, but that isn't used by the ios_app template. If somebody actually uses
this value, they'll get an error, so it's better to not pretend to support it.

The test template also forwarded visibility which was never used by ios_app.
This should be used so is now hooked up to the group generated by ios_app.
==========

[commit-bot: I haz the power, 2016-03-14 20:19:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-14 20:20:47]

Description was changed from

==========
Update iOS GN templates.

The test template was forwarding output_name and output_extension to the ios_app
template, but that isn't used by the ios_app template. If somebody actually uses
this value, they'll get an error, so it's better to not pretend to support it.

The test template also forwarded visibility which was never used by ios_app.
This should be used so is now hooked up to the group generated by ios_app.
==========

to

==========
Update iOS GN templates.

The test template was forwarding output_name and output_extension to the ios_app
template, but that isn't used by the ios_app template. If somebody actually uses
this value, they'll get an error, so it's better to not pretend to support it.

The test template also forwarded visibility which was never used by ios_app.
This should be used so is now hooked up to the group generated by ios_app.

Committed: https://crrev.com/71f8ea104d391816e5ca040534dcc3b288b0a59b
Cr-Commit-Position: refs/heads/master@{#381057}
==========

[commit-bot: I haz the power, 2016-03-14 20:20:48]

Patchset 1 (id:??) landed as
https://crrev.com/71f8ea104d391816e5ca040534dcc3b288b0a59b
Cr-Commit-Position: refs/heads/master@{#381057}

[sdefresne, 2016-03-15 12:13:22]

lgtm