Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: third_party/harfbuzz-ng/harfbuzz.gyp

Issue 1801813002: Decouple use_system_harfbuzz=1 from is_chromeos=1 & is_linux build flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 '../../build/win_precompile.gypi', 7 '../../build/win_precompile.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 'conditions': [ 10 # Only overriden by the official Chromium OS builds which are done
11 ['OS=="linux" and chromeos==1', { 11 # against the Chromium OS SDK in a chroot. Should not be needed in any
12 # Since version 1.31.0, pangoft2 which we depend on pulls in harfbuzz 12 # other configuration.
13 # anyways. However, we want to have control of the version of harfbuzz 13 # We need to be controlling the version of HarfBuzz used by Blink, as
14 # we use, so don't use system harfbuzz unless we are building for 14 # the correctness and good performance of text processing is only
15 # chrome os, where we have the system harfbuzz under control. 15 # guaranteed and supported against the version of HarfBuzz that is in
16 'use_system_harfbuzz%': '<!(python ../../build/check_return_value.py <(p kg-config) --atleast-version=1.31.0 pangoft2)', 16 # third_party/harfbuzz-ng. So, on all other platforms HarfBuzz is
17 }, { 17 # statically linked, on Chrome OS it is controlled as well, but part
18 'use_system_harfbuzz': 0, 18 # of the system.
19 }], 19 'use_system_harfbuzz%': 0,
20 ],
21 }, 20 },
22 'conditions': [ 21 'conditions': [
23 ['use_system_harfbuzz==0', { 22 ['use_system_harfbuzz==0', {
24 'targets': [ 23 'targets': [
25 { 24 {
26 'target_name': 'harfbuzz-ng', 25 'target_name': 'harfbuzz-ng',
27 'type': 'static_library', 26 'type': 'static_library',
28 'defines': [ 27 'defines': [
29 'HAVE_OT', 28 'HAVE_OT',
30 'HAVE_ICU', 29 'HAVE_ICU',
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 ], 205 ],
207 'libraries': [ 206 'libraries': [
208 '<!@(<(pkg-config) --libs-only-l harfbuzz)', 207 '<!@(<(pkg-config) --libs-only-l harfbuzz)',
209 ], 208 ],
210 }, 209 },
211 }, 210 },
212 ], 211 ],
213 }], 212 }],
214 ], 213 ],
215 } 214 }
OLDNEW
« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698