Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801793003: Move mojo::{Wait,WaitMany}() to (the newly-added) mojo/public/cpp/system/wait.h. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move mojo::{Wait,WaitMany}() to (the newly-added) mojo/public/cpp/system/wait.h. This mirrors the change in mojo/public/c/system. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/db4aa7c909c845f39a27afc1485a8ff836d880e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -99 lines) Patch
M examples/audio_play_test/play_wav.cc View 1 chunk +1 line, -0 lines 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 1 chunk +1 line, -0 lines 0 comments Download
M examples/wget/wget.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/data_pipe_utils/data_pipe_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/embedder/multiprocess_embedder_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/message_pump/message_pump_mojo.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/system/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/system/handle.h View 2 chunks +2 lines, -99 lines 0 comments Download
M mojo/public/cpp/system/tests/core_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/cpp/system/wait.h View 1 chunk +118 lines, -0 lines 0 comments Download
M mojo/public/cpp/test_support/lib/test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/utility/lib/run_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/platform/dart/mojo_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/js/system/core.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/tracing/tracing_app.cc View 1 chunk +1 line, -0 lines 0 comments Download
M shell/application_manager/data_pipe_peek.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 9 months ago (2016-03-14 17:54:13 UTC) #1
jamesr
lgtm
4 years, 9 months ago (2016-03-14 18:07:36 UTC) #2
viettrungluu
4 years, 9 months ago (2016-03-14 18:09:27 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
db4aa7c909c845f39a27afc1485a8ff836d880e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698