Remove the CREATE_RF_SWAPPED_OUT flag.

Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1b0f31db2e56b64a280bd4cfc04c1e9c1d151745
Cr-Commit-Position: refs/heads/master@{#381062}

[nasko, 2016-03-14 16:21:27]

Description was changed from

==========
Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
==========

to

==========
Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2016-03-14 16:22:49]

Description was changed from

==========
Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2016-03-14 16:29:52]

nasko@chromium.org changed reviewers:
+ alexmos@chromium.org

[nasko, 2016-03-14 16:29:53]

Hey Alex,
Can you review this CL for me? It removes an obsolete flag.
Thanks!
Nasko

[alexmos, 2016-03-14 16:57:20]

Just one quick question on the DCHECK below, otherwise looks good.

Also, the comment on RFHM::CreateRenderFrame needs to be updated:

  // Creates and initializes a RenderFrameHost. If |flags| has the
  // CREATE_RF_SWAPPED_OUT bit set from the CreateRenderFrameFlags enum, it will
  // initially be placed on the swapped out hosts list. If |view_routing_id_ptr|
  // is not nullptr it will be set to the routing id of the view associated with
  // the frame.
  scoped_ptr<RenderFrameHostImpl> CreateRenderFrame(SiteInstance* instance,
                                                    int flags,
                                                    int* view_routing_id_ptr);

(aside: is there a way to add a review comment on a file that's not part of the
CL?)

https://codereview.chromium.org/1801783003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_impl.h (right):

https://codereview.chromium.org/1801783003/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_impl.h:94: CREATE_RF_HIDDEN = 1 <<
0,
We added the flags enum when going from three to four bools, now we're down to
one.  Just wondering if we still want to keep the enum. :)

https://codereview.chromium.org/1801783003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/1801783003/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:1583: DCHECK(!(flags &
CREATE_RF_HIDDEN));
Is this correct?  Previously it basically had DCHECK_IMPLIES(swapped_out,
CREATE_RF_HIDDEN), now it says unconditionally that we should not be hidden,
which doesn't follow from the previous check.  Do we still need the check at
all?

[nasko, 2016-03-14 17:27:39]

Fixed comment in header file too. Not sure if there is a way to leave comments
on non-changed files, I haven't seen such way.

https://codereview.chromium.org/1801783003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_impl.h (right):

https://codereview.chromium.org/1801783003/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_impl.h:94: CREATE_RF_HIDDEN = 1 <<
0,
On 2016/03/14 16:57:20, alexmos wrote:
> We added the flags enum when going from three to four bools, now we're down to
> one.  Just wondering if we still want to keep the enum. :)

No, we don't. However, I want the few CLs I'm pushing out to only touch swapped
out relevant code. I'll convert this to boolean separately.

https://codereview.chromium.org/1801783003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/1801783003/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.cc:1583: DCHECK(!(flags &
CREATE_RF_HIDDEN));
On 2016/03/14 16:57:20, alexmos wrote:
> Is this correct?  Previously it basically had DCHECK_IMPLIES(swapped_out,
> CREATE_RF_HIDDEN), now it says unconditionally that we should not be hidden,
> which doesn't follow from the previous check.  Do we still need the check at
> all?

Done.

[alexmos, 2016-03-14 18:10:55]

LGTM

[nasko, 2016-03-14 18:12:40]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-03-14 18:13:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801783003/20001

[commit-bot: I haz the power, 2016-03-14 20:40:27]

Description was changed from

==========
Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-03-14 20:40:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-14 20:41:43]

Description was changed from

==========
Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove the CREATE_RF_SWAPPED_OUT flag.

Since swapped out state is no longer used, the flag is obsolete.

BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/1b0f31db2e56b64a280bd4cfc04c1e9c1d151745
Cr-Commit-Position: refs/heads/master@{#381062}
==========

[commit-bot: I haz the power, 2016-03-14 20:41:44]

Patchset 2 (id:??) landed as
https://crrev.com/1b0f31db2e56b64a280bd4cfc04c1e9c1d151745
Cr-Commit-Position: refs/heads/master@{#381062}