third_party/WebKit/Source/core/frame/VisualViewport.cpp - Issue 1801753002: First programmatic smooth scroll should run on the compositor if it can

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 1801753002: First programmatic smooth scroll should run on the compositor if it can (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase master Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameView.cpp ('K') | « third_party/WebKit/Source/core/frame/VisualViewport.h ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h » ('j') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

index 36f962068c3dd39c9ee25752b4aa7b901fa75685..2eed0b2b5dc6eb08cf76ff10e1d59e9ef2ba2648 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

@@ -721,6 +721,12 @@ bool VisualViewport::shouldDisableDesktopWorkarounds() const

|| (constraints.minimumScale == constraints.maximumScale && constraints.minimumScale != -1);

}

+CompositorAnimationTimeline* VisualViewport::compositorAnimationTimeline() const

+ ScrollingCoordinator* c = frameHost().page().scrollingCoordinator();

+ return c ? c->compositorAnimationTimeline() : 0;

jbroman 2016/03/14 17:35:32 Prefer nullptr to 0.

ymalik 2016/03/14 21:45:39 Done.

String VisualViewport::debugName(const GraphicsLayer* graphicsLayer) const

{

String name;