Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 1801753002: First programmatic smooth scroll should run on the compositor if it can (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bot compile error Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 124
125 // This getter will create a ScrollAnimatorBase if it doesn't already exist. 125 // This getter will create a ScrollAnimatorBase if it doesn't already exist.
126 ScrollAnimatorBase& scrollAnimator() const; 126 ScrollAnimatorBase& scrollAnimator() const;
127 127
128 // This getter will return null if the ScrollAnimatorBase hasn't been create d yet. 128 // This getter will return null if the ScrollAnimatorBase hasn't been create d yet.
129 ScrollAnimatorBase* existingScrollAnimator() const { return m_scrollAnimator .get(); } 129 ScrollAnimatorBase* existingScrollAnimator() const { return m_scrollAnimator .get(); }
130 130
131 ProgrammaticScrollAnimator& programmaticScrollAnimator() const; 131 ProgrammaticScrollAnimator& programmaticScrollAnimator() const;
132 ProgrammaticScrollAnimator* existingProgrammaticScrollAnimator() const { ret urn m_programmaticScrollAnimator.get(); } 132 ProgrammaticScrollAnimator* existingProgrammaticScrollAnimator() const { ret urn m_programmaticScrollAnimator.get(); }
133 133
134 virtual CompositorAnimationTimeline* compositorAnimationTimeline() const { r eturn nullptr; }
135
134 const IntPoint& scrollOrigin() const { return m_scrollOrigin; } 136 const IntPoint& scrollOrigin() const { return m_scrollOrigin; }
135 bool scrollOriginChanged() const { return m_scrollOriginChanged; } 137 bool scrollOriginChanged() const { return m_scrollOriginChanged; }
136 138
137 139
138 // This is used to determine whether the incoming fractional scroll offset s hould 140 // This is used to determine whether the incoming fractional scroll offset s hould
139 // be truncated to integer. Current rule is that if preferCompositingToLCDTe xtEnabled() 141 // be truncated to integer. Current rule is that if preferCompositingToLCDTe xtEnabled()
140 // is disabled (which is true on low-dpi device by default) we should do the truncation. 142 // is disabled (which is true on low-dpi device by default) we should do the truncation.
141 // The justification is that non-composited elements using fractional scroll offsets 143 // The justification is that non-composited elements using fractional scroll offsets
142 // is causing too much nasty bugs but does not add too benefit on low-dpi de vices. 144 // is causing too much nasty bugs but does not add too benefit on low-dpi de vices.
143 virtual bool shouldUseIntegerScrollOffset() const { return !RuntimeEnabledFe atures::fractionalScrollOffsetsEnabled(); } 145 virtual bool shouldUseIntegerScrollOffset() const { return !RuntimeEnabledFe atures::fractionalScrollOffsetsEnabled(); }
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 // vertical-lr / ltr NO NO 343 // vertical-lr / ltr NO NO
342 // vertical-lr / rtl NO YES 344 // vertical-lr / rtl NO YES
343 // vertical-rl / ltr YES NO 345 // vertical-rl / ltr YES NO
344 // vertical-rl / rtl YES YES 346 // vertical-rl / rtl YES YES
345 IntPoint m_scrollOrigin; 347 IntPoint m_scrollOrigin;
346 }; 348 };
347 349
348 } // namespace blink 350 } // namespace blink
349 351
350 #endif // ScrollableArea_h 352 #endif // ScrollableArea_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698