third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html - Issue 1801753002: First programmatic smooth scroll should run on the compositor if it can

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html

Issue 1801753002: First programmatic smooth scroll should run on the compositor if it can (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase master Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor-expected.txt » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../../resources/js-test.js"></script>

	3 <style>

	4 body {

	5 width: 2000px;

	6 height: 2000px;

	7 }

	8 </style>

	9

	10 <script>

	11 var jsTestIsAsync = true;

	12

	13 description("This test verifies that the first programmatic smooth scroll " +

	14 "doesn't always run on the main thread (see crbug.com/592799).");

	15

	16 // From ScrollingCoordinator::mainThreadScrollingReasonsAsText.
	skobes 2016/03/14 17:37:48 nit: actually from ScrollAnimatorCompositorCoordin nit: actually from ScrollAnimatorCompositorCoordinator::RunState ymalik 2016/03/14 21:45:39 Thanks, copy paste error. Show quoted text On 2016/03/14 17:37:48, skobes wrote: > nit: actually from ScrollAnimatorCompositorCoordinator::RunState Thanks, copy paste error.
	17 var RUNNING_ON_COMPOSITOR = 2;

	18

	19 function runTest() {

	20 if (document.scrollingElement.scrollTop == 0) {

	21 requestAnimationFrame(runTest);

	22 } else {

	23 // Check that initiated by main thread and running on the compositor.

	24 shouldBeTrue("internals.getProgrammaticScrollAnimationState(document) " +
	jbroman 2016/03/14 17:35:32 nit: equality comparison is why shouldBe exists: nit: equality comparison is why shouldBe exists: shouldBe("internals.getProgrammaticScrollAnimationState(document)", "RUNNING_ON_COMPOSITOR"); ymalik 2016/03/14 21:45:39 Done. Show quoted text On 2016/03/14 17:35:32, jbroman wrote: > nit: equality comparison is why shouldBe exists: > > shouldBe("internals.getProgrammaticScrollAnimationState(document)", > "RUNNING_ON_COMPOSITOR"); Done.
	25 "== RUNNING_ON_COMPOSITOR");

	26 shouldBecomeEqual("document.scrollingElement.scrollTop == 500",

	27 "true", finishJSTest);

	28 }

	29 }

	30

	31 onload = function() {

	32 if (!window.internals) {

	33 debug("This test requires window.internals.");

	34 finishJSTest();

	35 return;

	36 }

	37

	38 document.scrollingElement.scrollTop = 0;

	39

	40 window.scrollBy({top: 500, behavior: "smooth"});

	41

	42 runTest();

	43 };

	44

	45 </script>

OLD	NEW