Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1801733002: Mark SyncTest#testStopAndStartSyncThroughAndroid as flaky (Closed)

Created:
4 years, 9 months ago by May
Modified:
4 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark SyncTest#testStopAndStartSyncThroughAndroid as flaky BUG=594558 Committed: https://crrev.com/a7f875ca7a0949cbbaafa9aed15562efc3c5b80c Cr-Commit-Position: refs/heads/master@{#380985}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment asterisks #

Patch Set 3 : Fix comment asterisks #

Total comments: 1

Patch Set 4 : Fix BUG= link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
May
4 years, 9 months ago (2016-03-14 14:55:31 UTC) #2
Bernhard Bauer
LGTM with nits: https://codereview.chromium.org/1801733002/diff/1/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java File chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java (right): https://codereview.chromium.org/1801733002/diff/1/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java#newcode124 chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java:124: /*@LargeTest Break after opening the comment, ...
4 years, 9 months ago (2016-03-14 15:23:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801733002/40001
4 years, 9 months ago (2016-03-14 15:27:20 UTC) #6
Bernhard Bauer
https://codereview.chromium.org/1801733002/diff/40001/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java File chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java (right): https://codereview.chromium.org/1801733002/diff/40001/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java#newcode127 chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java:127: * BUG = 594558 Ahem... crbug.com/594558 pls ☺
4 years, 9 months ago (2016-03-14 15:30:50 UTC) #7
May
On 2016/03/14 15:30:50, bauerb catching up on reviews wrote: > https://codereview.chromium.org/1801733002/diff/40001/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java > File > chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java ...
4 years, 9 months ago (2016-03-14 15:39:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801733002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801733002/60001
4 years, 9 months ago (2016-03-14 15:44:18 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-14 16:18:21 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 16:19:25 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a7f875ca7a0949cbbaafa9aed15562efc3c5b80c
Cr-Commit-Position: refs/heads/master@{#380985}

Powered by Google App Engine
This is Rietveld 408576698