Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801633003: Add parsing for type queries (Closed)

Created:
4 years, 9 months ago by nickie
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@types
Target Ref:
refs/pending/heads/experimental/nikolaos/types
Project:
v8
Visibility:
Public.

Description

Add parsing for type queries R=rossberg@chromium.org NOTRY=true NOPRESUBMIT=true BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -1 line) Patch
M src/ast/ast.h View 3 chunks +28 lines, -0 lines 0 comments Download
M src/parsing/parser.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/parsing/parser-base.h View 5 chunks +26 lines, -1 line 2 comments Download
M src/parsing/preparser.h View 4 chunks +14 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typesystem/type-query.js View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nickie
4 years, 9 months ago (2016-03-14 12:55:07 UTC) #1
rossberg
https://codereview.chromium.org/1801633003/diff/1/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/1801633003/diff/1/src/parsing/parser-base.h#newcode3353 src/parsing/parser-base.h:3353: typename ParserBase<Traits>::IdentifierListT Doesn't make much sense to allow identifier ...
4 years, 9 months ago (2016-03-17 12:34:09 UTC) #2
rossberg
lgtm https://codereview.chromium.org/1801633003/diff/1/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/1801633003/diff/1/src/parsing/parser-base.h#newcode3353 src/parsing/parser-base.h:3353: typename ParserBase<Traits>::IdentifierListT On 2016/03/17 12:34:09, rossberg wrote: > ...
4 years, 9 months ago (2016-03-17 12:37:17 UTC) #3
nickie
4 years, 9 months ago (2016-03-17 13:16:30 UTC) #4 
Patchset 1 landed MANUALLY in experimental/nikolaos/types as:
27b77725ff56d372606e48deb2fd6f986b0feca7
https://chromium.googlesource.com/v8/v8/+/27b77725ff56d372606e48deb2fd6f986b0...

Powered by Google App Engine
This is Rietveld 408576698