Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 180163013: Copying the following files AS-IS from google.glog r141: (Closed)

Created:
6 years, 9 months ago by ivanpe.google
Modified:
6 years, 9 months ago
Reviewers:
awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Copying the following files AS-IS from google.glog r141: - demangle.cc - demangle.h - symbolize.cc - symbolize.h The new functionality is a callback mechanism to allow users of google.glog to provide their own implementation of OpenObjectFileContainingPcAndGetStartAddress. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -173 lines) Patch
M base/base.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M base/third_party/symbolize/README.chromium View 1 chunk +1 line, -4 lines 0 comments Download
M base/third_party/symbolize/demangle.cc View 46 chunks +226 lines, -153 lines 0 comments Download
M base/third_party/symbolize/symbolize.h View 2 chunks +22 lines, -0 lines 0 comments Download
M base/third_party/symbolize/symbolize.cc View 9 chunks +181 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
ivanpe.google
Hi Albert, you already approved this change previously: https://codereview.chromium.org/183763004/ Unfortunately, it was uploaded accidentally using ...
6 years, 9 months ago (2014-03-04 06:24:03 UTC) #1
awong
LGTM
6 years, 9 months ago (2014-03-04 06:57:47 UTC) #2
ivanpe.google
The CQ bit was checked by ivanpe@google.com
6 years, 9 months ago (2014-03-04 18:36:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivanpe@google.com/180163013/1
6 years, 9 months ago (2014-03-04 18:36:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 20:49:12 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=274288
6 years, 9 months ago (2014-03-04 20:49:13 UTC) #6
ivanpe.google
The CQ bit was checked by ivanpe@google.com
6 years, 9 months ago (2014-03-05 00:55:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivanpe@google.com/180163013/1
6 years, 9 months ago (2014-03-05 01:36:52 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 05:55:48 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-05 05:55:48 UTC) #10
ivanpe.google
The CQ bit was checked by ivanpe@google.com
6 years, 9 months ago (2014-03-05 06:34:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivanpe@google.com/180163013/1
6 years, 9 months ago (2014-03-05 06:36:55 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 10:16:04 UTC) #13
Message was sent while issue was closed.
Change committed as 254996

Powered by Google App Engine
This is Rietveld 408576698