Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 180163010: IndexedDB: Don't timeout read-only transactions (Closed)

Created:
6 years, 9 months ago by jsbell
Modified:
6 years, 9 months ago
Reviewers:
dgrogan, cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

IndexedDB: Don't timeout read-only transactions Chrome introduced a transaction timeout to deal with potentially wedged renderers (e.g. JS execution halted, etc) failing to complete transactions, leaving the browser's transaction queue in a bad state. This was done for all transactions, but since read-only transactions don't hold up the queue it's safe to ignore them, which can reduce false-positives. BUG=339229 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255673

Patch Set 1 #

Patch Set 2 : Abort the transaction to avoid leaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M content/browser/indexed_db/indexed_db_transaction.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_unittest.cc View 1 2 chunks +33 lines, -1 line 0 comments Download

Messages

Total messages: 27 (0 generated)
jsbell
dgrogan@, cmumford@ - PTAL?
6 years, 9 months ago (2014-03-03 22:18:13 UTC) #1
dgrogan
lgtm
6 years, 9 months ago (2014-03-04 01:30:27 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 9 months ago (2014-03-04 17:15:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/1
6 years, 9 months ago (2014-03-04 17:16:19 UTC) #4
commit-bot: I haz the power
Change committed as 254846
6 years, 9 months ago (2014-03-04 22:10:10 UTC) #5
stgao
A revert of this CL has been created in https://codereview.chromium.org/185403019/ by stgao@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-04 22:59:22 UTC) #6
jsbell
Bah, just need to abort the transaction so it all gets cleaned up.
6 years, 9 months ago (2014-03-04 23:02:38 UTC) #7
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 9 months ago (2014-03-06 18:45:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
6 years, 9 months ago (2014-03-06 18:50:56 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 19:07:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 19:07:56 UTC) #11
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 9 months ago (2014-03-06 19:08:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
6 years, 9 months ago (2014-03-06 19:15:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
6 years, 9 months ago (2014-03-06 21:00:11 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 21:29:12 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 21:29:12 UTC) #16
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 9 months ago (2014-03-07 00:53:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
6 years, 9 months ago (2014-03-07 00:59:38 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 03:47:46 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 03:47:47 UTC) #20
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 9 months ago (2014-03-07 18:18:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
6 years, 9 months ago (2014-03-07 18:20:32 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 18:25:08 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 18:25:09 UTC) #24
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 9 months ago (2014-03-07 18:41:44 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
6 years, 9 months ago (2014-03-07 18:43:51 UTC) #26
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 19:00:58 UTC) #27
Message was sent while issue was closed.
Change committed as 255673

Powered by Google App Engine
This is Rietveld 408576698