|
|
Created:
6 years, 9 months ago by jsbell Modified:
6 years, 9 months ago CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionIndexedDB: Don't timeout read-only transactions
Chrome introduced a transaction timeout to deal with potentially wedged
renderers (e.g. JS execution halted, etc) failing to complete transactions,
leaving the browser's transaction queue in a bad state. This was done
for all transactions, but since read-only transactions don't hold up
the queue it's safe to ignore them, which can reduce false-positives.
BUG=339229
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254846
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255673
Patch Set 1 #Patch Set 2 : Abort the transaction to avoid leaks #
Messages
Total messages: 27 (0 generated)
dgrogan@, cmumford@ - PTAL?
lgtm
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/1
Message was sent while issue was closed.
Change committed as 254846
Message was sent while issue was closed.
A revert of this CL has been created in https://codereview.chromium.org/185403019/ by stgao@chromium.org. The reason for reverting is: Break Chromium Memory on Linux ASan+LSan Tests (2) http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Te....
Bah, just need to abort the transaction so it all gets cleaned up.
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg
The CQ bit was checked by jsbell@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/180163010/20001
Message was sent while issue was closed.
Change committed as 255673 |