chrome.bluetooth API improvements.

device/bluetooth/bluetooth_device.h

Index: device/bluetooth/bluetooth_device.h
diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
index cb1e7ec6994f4ad565b5c5d2a36e9f0d795079ac..8beef1ff9636b8e9147cc0016a90c52a3280cbbe 100644
--- a/device/bluetooth/bluetooth_device.h
+++ b/device/bluetooth/bluetooth_device.h
@@ -11,6 +11,7 @@
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
+#include "net/base/net_log.h"
 
 namespace device {
 
@@ -240,7 +241,7 @@ class BluetoothDevice {
 
   // The ErrorCallback is used for methods that can fail in which case it
   // is called, in the success case the callback is simply not called.
-  typedef base::Callback<void()> ErrorCallback;
+  typedef base::Callback<void(const std::string&)> ErrorCallback;

[keybuk, 2014/03/20 01:21:56]

What are the possible values of this string?
Is this pre-translated?
Feels like it should be an enum.

[rpaquay, 2014/03/20 18:21:11]

The intent is to provide a descriptive error message to the App, which will
eventually end up in "chrome.lastError.message". There was a precedent was
"BluetoothSocket::getLastErrorMessage()", which I also replaced with a error
callback with a "std::string error" parameter -- getLastErrorMessage was simply
too tricky to deal with with an asynchronous API, imho.

[keybuk, 2014/03/20 18:38:40]

Okay, is the policy that those are always English? Would there be a standard set
of error messages across platforms, or would Chrome OS return different error
strings to Windows for the same error?

Also I thought Manifests v3 was trying to get rid of lastError?


If always English, and okay for platform-different errors, I'm okay with this
staying - but since ErrorCallback is used for other methods like Disconnect()
and Forget(), this should be a new callback for the ConnectToProfile case only

[rpaquay, 2014/03/25 20:06:10]

Yeah, the message are always English, and platform dependent errors are allowed
(On MacOs, for example, having the IOReturn from the IOBluetoothXxx calls
somewhere in the error message could be useful).

As for Manifest v3, my guess is that lastError is going to be replaced with some
sort of exception mechanism. I think we are trying to get rid of the specific
mechanics of using a global variable (lastError), not the ability to have "dev"
English only error messages.

I will change the CL to make the callback specific to ConnecToProfile.

 
   // The ConnectErrorCallback is used for methods that can fail with an error,
   // passed back as an error code argument to this callback.