Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180163008: Fix sub-pixel handling of transparency layers (Closed)

Created:
6 years, 9 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix sub-pixel handling of transparency layers Transparency layers were implemented before composited layers were made to be fully sub-pixel aware. Blink r164561 was the sub-pixel fix for composited layers, which caused them to behave differently than transparency layers leading to off-by-one errors. This patch teaches transparency layers about sub-pixel. BUG=347521 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168450

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : 500's :-/ #

Patch Set 4 : Round 3 #

Patch Set 5 : I hate reitveldt #

Total comments: 1

Patch Set 6 : Adding test expectations and link to bug #

Patch Set 7 : Fix and removed test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -22 lines) Patch
A LayoutTests/fast/sub-pixel/sub-pixel-transparency-layer.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/sub-pixel/sub-pixel-transparency-layer-expected.html View 1 chunk +31 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 4 5 6 13 chunks +24 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
leviw_travelin_and_unemployed
6 years, 9 months ago (2014-03-03 19:36:04 UTC) #1
eae
I hate rietveld too... LGTM w/nit https://codereview.chromium.org/180163008/diff/40002/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/180163008/diff/40002/Source/core/rendering/RenderLayer.cpp#newcode2957 Source/core/rendering/RenderLayer.cpp:2957: // FIXME: We're ...
6 years, 9 months ago (2014-03-03 19:56:11 UTC) #2
leviw_travelin_and_unemployed
On 2014/03/03 19:56:11, eae wrote: > I hate rietveld too... LGTM w/nit Thanks! > > ...
6 years, 9 months ago (2014-03-03 20:21:37 UTC) #3
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-04 01:14:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/180163008/100001
6 years, 9 months ago (2014-03-04 01:14:46 UTC) #5
leviw_travelin_and_unemployed
The CQ bit was unchecked by leviw@chromium.org
6 years, 9 months ago (2014-03-04 18:27:53 UTC) #6
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-04 18:27:53 UTC) #7
leviw_travelin_and_unemployed
On 2014/03/04 01:14:46, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 9 months ago (2014-03-04 18:28:14 UTC) #8
leviw_travelin_and_unemployed
The CQ bit was unchecked by leviw@chromium.org
6 years, 9 months ago (2014-03-04 21:34:54 UTC) #9
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-04 21:34:55 UTC) #10
leviw_travelin_and_unemployed
On 2014/03/04 21:34:55, Levi wrote: > The CQ bit was checked by mailto:leviw@chromium.org 27 hours! ...
6 years, 9 months ago (2014-03-05 04:21:22 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 08:51:40 UTC) #12
Message was sent while issue was closed. 
Change committed as 168450

Powered by Google App Engine
This is Rietveld 408576698