Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1298)

Unified Diff: media/filters/legacy_frame_processor.cc

Issue 180153003: Implement core of compliant MediaSource coded frame processing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT in preparation for dcommit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/frame_processor_unittest.cc ('k') | media/filters/pipeline_integration_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/legacy_frame_processor.cc
diff --git a/media/filters/legacy_frame_processor.cc b/media/filters/legacy_frame_processor.cc
index 71c280183f2d2f74026d89dae8074f23737c5c44..ef8f89f92281917bb5940e3f8c813b5cdac07920 100644
--- a/media/filters/legacy_frame_processor.cc
+++ b/media/filters/legacy_frame_processor.cc
@@ -50,10 +50,6 @@ bool LegacyFrameProcessor::ProcessFrames(
MseTrackBuffer* video_track = FindTrack(kVideoTrackId);
DCHECK(video_buffers.empty() || video_track);
- // TODO(wolenetz): DCHECK + return false if any of these buffers have UNKNOWN
- // type() in upcoming coded frame processing compliant implementation. See
- // http://crbug.com/249422.
-
StreamParser::BufferQueue filtered_audio;
StreamParser::BufferQueue filtered_video;
StreamParser::TextBufferQueueMap filtered_text;
@@ -110,13 +106,8 @@ bool LegacyFrameProcessor::ProcessFrames(
}
*new_media_segment = false;
-
DCHECK(segment_timestamp != kInfiniteDuration());
- for (TrackBufferMap::iterator itr = track_buffers_.begin();
- itr != track_buffers_.end();
- ++itr) {
- itr->second->stream()->OnNewMediaSegment(segment_timestamp);
- }
+ NotifyNewMediaSegmentStarting(segment_timestamp);
}
if (!filtered_audio.empty() &&
« no previous file with comments | « media/filters/frame_processor_unittest.cc ('k') | media/filters/pipeline_integration_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698