Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1801523002: [Media Router WebUI] Remove cosmetic styling on focused "Share your screen" subheading. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Remove cosmetic styling on focused "Share your screen" subheading. Visible styling when "Share your screen" is focused gives an impression that it's clickable/will do something. This change removes the cosmetic styling. We still want this to be focusable for accessibility reasons, so focus is not disabled for this text. BUG=590688 Committed: https://crrev.com/89fa440fdd71e96da75a9570d99acb25b63be812 Cr-Commit-Position: refs/heads/master@{#381367}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
apacible
PTAL, thanks!
4 years, 9 months ago (2016-03-14 17:30:55 UTC) #6
imcheng
lgtm
4 years, 9 months ago (2016-03-15 21:37:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801523002/40001
4 years, 9 months ago (2016-03-15 23:26:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 9 months ago (2016-03-16 00:35:14 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 00:37:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89fa440fdd71e96da75a9570d99acb25b63be812
Cr-Commit-Position: refs/heads/master@{#381367}

Powered by Google App Engine
This is Rietveld 408576698