third_party/WebKit/Source/core/dom/ScriptLoader.cpp - Issue 1801513003: Cross origin requests to same origin should match

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 1801513003: Cross origin requests to same origin should match Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing CORS tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

index b33f34f19aa2891a85c1daa62870e688f9a8b4e0..03a45ab7d7e6b41cc6c6efbf8e14232f04a839de 100644

--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

@@ -292,8 +292,7 @@ bool ScriptLoader::fetchScript(const String& sourceUrl, FetchRequest::DeferOptio

FetchRequest request(ResourceRequest(elementDocument->completeURL(sourceUrl)), m_element->localName());

CrossOriginAttributeValue crossOrigin = crossOriginAttributeValue(m_element->fastGetAttribute(HTMLNames::crossoriginAttr));

- if (crossOrigin != CrossOriginAttributeNotSet)

- request.setCrossOriginAccessControl(elementDocument->getSecurityOrigin(), crossOrigin);

+ request.setCrossOriginAccessControl(elementDocument->getSecurityOrigin(), crossOrigin);

request.setCharset(scriptCharset());

// Skip fetch-related CSP checks if the script element has a valid nonce, or if dynamically