Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1801513002:
[Media Router WebUI] Use pointer cursor on share screen text. (Closed)
|
Created:
4 years, 9 months ago by apacible Modified:
4 years, 9 months ago Reviewers:
imcheng CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Media Router WebUI] Use pointer cursor on share screen text.
Currently the cursor a 'text' style cursor. Use the pointer cursor so there's no visual cue that the "Share your screen" is selectable.
BUG=590704
Committed: https://crrev.com/98281f57aabf7bc3e9bd02ca3844f7aa8558359c
Cr-Commit-Position: refs/heads/master@{#381485}
Patch Set 1 : #Patch Set 2 : Rebase. #Messages
Total messages: 24 (13 generated)
Description was changed from ========== asdf BUG= ========== to ========== [Media Router WebUI] Use pointer cursor on share screen text. Currently the cursor a 'text' style cursor. Use the pointer cursor so there's no visual cue that the "Share your screen" is selectable. BUG=590704 ==========
Patchset #1 (id:1) has been deleted
apacible@chromium.org changed reviewers: + imcheng@chromium.org
PTAL, thanks!
lgtm
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801513002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801513002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801513002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by apacible@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org Link to the patchset: https://codereview.chromium.org/1801513002/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801513002/40001
Message was sent while issue was closed.
Description was changed from ========== [Media Router WebUI] Use pointer cursor on share screen text. Currently the cursor a 'text' style cursor. Use the pointer cursor so there's no visual cue that the "Share your screen" is selectable. BUG=590704 ========== to ========== [Media Router WebUI] Use pointer cursor on share screen text. Currently the cursor a 'text' style cursor. Use the pointer cursor so there's no visual cue that the "Share your screen" is selectable. BUG=590704 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Media Router WebUI] Use pointer cursor on share screen text. Currently the cursor a 'text' style cursor. Use the pointer cursor so there's no visual cue that the "Share your screen" is selectable. BUG=590704 ========== to ========== [Media Router WebUI] Use pointer cursor on share screen text. Currently the cursor a 'text' style cursor. Use the pointer cursor so there's no visual cue that the "Share your screen" is selectable. BUG=590704 Committed: https://crrev.com/98281f57aabf7bc3e9bd02ca3844f7aa8558359c Cr-Commit-Position: refs/heads/master@{#381485} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/98281f57aabf7bc3e9bd02ca3844f7aa8558359c Cr-Commit-Position: refs/heads/master@{#381485} |
