Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: test/unittests/interpreter/source-position-table-unittest.cc

Issue 1801473003: [ignition, debugger] correctly set position for return with elided bytecode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: do not use --ignition flag Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/mjsunit.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/source-position-table-unittest.cc
diff --git a/test/unittests/interpreter/source-position-table-unittest.cc b/test/unittests/interpreter/source-position-table-unittest.cc
index 22825cb229e1ad1d43290dca52abf3d894bf8a13..af70179ef454824d7aa2ed96edc759e56b1a2312 100644
--- a/test/unittests/interpreter/source-position-table-unittest.cc
+++ b/test/unittests/interpreter/source-position-table-unittest.cc
@@ -33,6 +33,26 @@ TEST_F(SourcePositionTableTest, EncodeStatement) {
CHECK(!builder.ToSourcePositionTable().is_null());
}
+TEST_F(SourcePositionTableTest, EncodeStatementDuplicates) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+ for (int i = 0; i < arraysize(offsets); i++) {
+ builder.AddStatementPosition(offsets[i], offsets[i]);
+ builder.AddStatementPosition(
+ offsets[i], offsets[i],
+ (i % 2 == 0) ? SourcePositionTableBuilder::OVERWRITE_DUPLICATE
+ : SourcePositionTableBuilder::DISCARD_DUPLICATE);
+ builder.AddStatementPosition(offsets[i], offsets[i]);
+ builder.AddStatementPosition(
+ offsets[i], offsets[i],
+ (i % 2 == 0) ? SourcePositionTableBuilder::OVERWRITE_DUPLICATE
+ : SourcePositionTableBuilder::DISCARD_DUPLICATE);
+ }
+
+ // To test correctness, we rely on the assertions in ToSourcePositionTable().
+ // (Also below.)
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
TEST_F(SourcePositionTableTest, EncodeExpression) {
SourcePositionTableBuilder builder(isolate(), zone());
for (int i = 0; i < arraysize(offsets); i++) {
« no previous file with comments | « test/mjsunit/mjsunit.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698