Source/core/dom/ChildNodeList.h - Issue 180143003: Have LiveNodeListBase::ownerNode() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ChildNodeList.h

Issue 180143003: Have LiveNodeListBase::ownerNode() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ChildNodeList.h

diff --git a/Source/core/dom/ChildNodeList.h b/Source/core/dom/ChildNodeList.h

index 0fe38cc7abdc24faa58e532c019570c05693df56..aab6861c3b2d1d309d1a8409e03dc818ede6de3d 100644

--- a/Source/core/dom/ChildNodeList.h

+++ b/Source/core/dom/ChildNodeList.h

@@ -46,10 +46,10 @@ public:

// Non-DOM API.

void invalidateCache() { m_collectionIndexCache.invalidate(); }

- ContainerNode* ownerNode() const { return m_parent.get(); }

+ ContainerNode& ownerNode() const { return *m_parent; }

// CollectionIndexCache API.

- ContainerNode& rootNode() const { return *m_parent; }

+ ContainerNode& rootNode() const { return ownerNode(); }

bool canTraverseBackward() const { return true; }

Node* itemBefore(const Node* previousItem) const;

Node* traverseToFirstElement(const ContainerNode& root) const { return root.firstChild(); }