Source/core/dom/LiveNodeListBase.h - Issue 180143003: Have LiveNodeListBase::ownerNode() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/LiveNodeListBase.h

Issue 180143003: Have LiveNodeListBase::ownerNode() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/LiveNodeListBase.h

diff --git a/Source/core/dom/LiveNodeListBase.h b/Source/core/dom/LiveNodeListBase.h

index 098d8ddfcce190a3990ec3465e337ff0c38c3ca4..ff219534d737dd8b990b5dca95943933b0d4d8a0 100644

--- a/Source/core/dom/LiveNodeListBase.h

+++ b/Source/core/dom/LiveNodeListBase.h

@@ -66,7 +66,7 @@ public:

ALWAYS_INLINE bool isRootedAtDocument() const { return m_rootType == NodeListIsRootedAtDocument || m_rootType == NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr; }

ALWAYS_INLINE NodeListInvalidationType invalidationType() const { return static_cast<NodeListInvalidationType>(m_invalidationType); }

ALWAYS_INLINE CollectionType type() const { return static_cast<CollectionType>(m_collectionType); }

- ContainerNode* ownerNode() const { return m_ownerNode.get(); }

+ ContainerNode& ownerNode() const { return *m_ownerNode; }

ALWAYS_INLINE void invalidateCache(const QualifiedName* attrName) const

{

if (!attrName || shouldInvalidateTypeOnAttributeChange(invalidationType(), *attrName))

« no previous file with comments | « Source/core/dom/LiveNodeList.cpp ('k') | Source/core/dom/NameNodeList.cpp » ('j') | Source/core/html/HTMLAllCollection.idl » ('J')