Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: Source/core/html/HTMLCollection.cpp

Issue 180143003: Have LiveNodeListBase::ownerNode() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLAllCollection.idl ('k') | Source/core/html/HTMLCollection.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved.
5 * Copyright (C) 2014 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 return adoptRef(new HTMLCollection(base, type, DoesNotOverrideItemAfter)); 174 return adoptRef(new HTMLCollection(base, type, DoesNotOverrideItemAfter));
175 } 175 }
176 176
177 HTMLCollection::~HTMLCollection() 177 HTMLCollection::~HTMLCollection()
178 { 178 {
179 if (hasValidIdNameCache()) 179 if (hasValidIdNameCache())
180 unregisterIdNameCacheFromDocument(document()); 180 unregisterIdNameCacheFromDocument(document());
181 // HTMLNameCollection, ClassCollection and TagCollection remove cache by the mselves. 181 // HTMLNameCollection, ClassCollection and TagCollection remove cache by the mselves.
182 if (type() != WindowNamedItems && type() != DocumentNamedItems && type() != ClassCollectionType 182 if (type() != WindowNamedItems && type() != DocumentNamedItems && type() != ClassCollectionType
183 && type() != HTMLTagCollectionType && type() != TagCollectionType) { 183 && type() != HTMLTagCollectionType && type() != TagCollectionType) {
184 ownerNode()->nodeLists()->removeCache(this, type()); 184 ownerNode().nodeLists()->removeCache(this, type());
185 } 185 }
186 } 186 }
187 187
188 void HTMLCollection::invalidateCache(Document* oldDocument) const 188 void HTMLCollection::invalidateCache(Document* oldDocument) const
189 { 189 {
190 m_collectionIndexCache.invalidate(); 190 m_collectionIndexCache.invalidate();
191 invalidateIdNameCacheMaps(oldDocument); 191 invalidateIdNameCacheMaps(oldDocument);
192 } 192 }
193 193
194 template <class NodeListType> 194 template <class NodeListType>
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 535
536 void HTMLCollection::append(NodeCacheMap& map, const AtomicString& key, Element* element) 536 void HTMLCollection::append(NodeCacheMap& map, const AtomicString& key, Element* element)
537 { 537 {
538 OwnPtr<Vector<Element*> >& vector = map.add(key.impl(), nullptr).storedValue ->value; 538 OwnPtr<Vector<Element*> >& vector = map.add(key.impl(), nullptr).storedValue ->value;
539 if (!vector) 539 if (!vector)
540 vector = adoptPtr(new Vector<Element*>); 540 vector = adoptPtr(new Vector<Element*>);
541 vector->append(element); 541 vector->append(element);
542 } 542 }
543 543
544 } // namespace WebCore 544 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLAllCollection.idl ('k') | Source/core/html/HTMLCollection.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698