Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: src/frames.h

Issue 18014003: Add X32 port into V8 (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/frames.h
===================================================================
--- src/frames.h (revision 15486)
+++ src/frames.h (working copy)
@@ -92,7 +92,11 @@
static const int kContextOffset = 3 * kPointerSize;
static const int kFPOffset = 4 * kPointerSize;
+#ifndef V8_TARGET_ARCH_X32
static const int kSize = kFPOffset + kPointerSize;
+#else
+ static const int kSize = kFPOffset + kHWRegSize;
danno 2013/07/17 13:33:21 There should be no platform-specific #ifs in this
+#endif
static const int kSlotCount = kSize >> kPointerSizeLog2;
};
@@ -168,6 +172,7 @@
// context and function.
// StandardFrame::IterateExpressions assumes that kContextOffset is the last
// object pointer.
+#ifndef V8_TARGET_ARCH_X32
static const int kFixedFrameSize = 4 * kPointerSize;
static const int kExpressionsOffset = -3 * kPointerSize;
static const int kMarkerOffset = -2 * kPointerSize;
@@ -175,6 +180,15 @@
static const int kCallerFPOffset = 0 * kPointerSize;
static const int kCallerPCOffset = +1 * kPointerSize;
static const int kCallerSPOffset = +2 * kPointerSize;
+#else
+ static const int kFixedFrameSize = 2 * kPointerSize + 2 * kHWRegSize;
danno 2013/07/17 13:33:21 See above, if you have the right constants, I thin
+ static const int kExpressionsOffset = -3 * kPointerSize;
+ static const int kMarkerOffset = -2 * kPointerSize;
+ static const int kContextOffset = -1 * kPointerSize;
+ static const int kCallerFPOffset = 0 * kPointerSize;
+ static const int kCallerPCOffset = +1 * kHWRegSize;
+ static const int kCallerSPOffset = +2 * kHWRegSize;
+#endif
};

Powered by Google App Engine
This is Rietveld 408576698