Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801393002: [DevTools] When selected network preset is remove, select another one. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] When selected network preset is remove, select another one. BUG=593255 Committed: https://crrev.com/f8966346f63433d6b15ad134828ea5f0bc2e1e01 Cr-Commit-Position: refs/heads/master@{#381460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js View 2 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-03-15 23:20:07 UTC) #2
pfeldman
lgtm
4 years, 9 months ago (2016-03-16 01:19:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801393002/1
4 years, 9 months ago (2016-03-16 01:38:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157434)
4 years, 9 months ago (2016-03-16 01:46:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801393002/1
4 years, 9 months ago (2016-03-16 16:02:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 16:08:14 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 16:09:24 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f8966346f63433d6b15ad134828ea5f0bc2e1e01
Cr-Commit-Position: refs/heads/master@{#381460}

Powered by Google App Engine
This is Rietveld 408576698