Chromium Code Reviews| Index: core/fxcodec/jbig2/JBig2_Context.cpp |
| diff --git a/core/fxcodec/jbig2/JBig2_Context.cpp b/core/fxcodec/jbig2/JBig2_Context.cpp |
| index 89157b9bf1d8d4f2c2e29987d7611c1583123cbf..805a102c740553d5d581cde2b98bab21188f5d62 100644 |
| --- a/core/fxcodec/jbig2/JBig2_Context.cpp |
| +++ b/core/fxcodec/jbig2/JBig2_Context.cpp |
| @@ -201,7 +201,7 @@ int32_t CJBig2_Context::getFirstPage(uint8_t* pBuf, |
| } |
| int32_t CJBig2_Context::Continue(IFX_Pause* pPause) { |
| m_ProcessingStatus = FXCODEC_STATUS_DECODE_READY; |
| - int32_t nRet; |
| + int32_t nRet = 0; |
| if (m_PauseStep <= 1) { |
|
Tom Sepez
2016/03/16 18:34:58
nit: pity m_PauseStep isn't an enum with a switch
Wei Li
2016/03/17 02:24:05
Won't help, a smarter compiler is needed
Tom Sepez
2016/03/17 16:40:05
Acknowledged.
|
| nRet = decode_EmbedOrgnazation(pPause); |
| } else if (m_PauseStep == 2) { |
| @@ -683,14 +683,14 @@ int32_t CJBig2_Context::parseTextRegion(CJBig2_Segment* pSegment) { |
| } |
| pTRD->SBRTEMPLATE = (wFlags >> 15) & 0x0001; |
| - uint8_t cSBHUFFFS; |
| - uint8_t cSBHUFFDS; |
| - uint8_t cSBHUFFDT; |
| - uint8_t cSBHUFFRDW; |
| - uint8_t cSBHUFFRDH; |
| - uint8_t cSBHUFFRDX; |
| - uint8_t cSBHUFFRDY; |
| - uint8_t cSBHUFFRSIZE; |
| + uint8_t cSBHUFFFS = 0; |
|
Tom Sepez
2016/03/16 18:34:59
yup. Good catch.
Wei Li
2016/03/17 02:24:05
Actually these would be assigned at line 698-693.
|
| + uint8_t cSBHUFFDS = 0; |
| + uint8_t cSBHUFFDT = 0; |
| + uint8_t cSBHUFFRDW = 0; |
| + uint8_t cSBHUFFRDH = 0; |
| + uint8_t cSBHUFFRDX = 0; |
| + uint8_t cSBHUFFRDY = 0; |
| + uint8_t cSBHUFFRSIZE = 0; |
| if (pTRD->SBHUFF == 1) { |
| if (m_pStream->readShortInteger(&wFlags) != 0) |
| return JBIG2_ERROR_TOO_SHORT; |