Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fpdfdoc/doc_ap.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fpdfapi/fpdf_render/fpdf_render_text.cpp ('K') | « core/fpdfapi/fpdf_render/fpdf_render_text.cpp ('k') | core/fpdftext/fpdf_text_int.cpp » ('j') | core/fpdftext/fpdf_text_int.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfdoc/doc_ap.cpp
diff --git a/core/fpdfdoc/doc_ap.cpp b/core/fpdfdoc/doc_ap.cpp
index 43dcfb4ac04f70523639e2a25195f8dd8255b928..9d048e6e8f50073a5304bd461a35ea9c5879494b 100644
--- a/core/fpdfdoc/doc_ap.cpp
+++ b/core/fpdfdoc/doc_ap.cpp
@@ -304,7 +304,7 @@ static FX_BOOL GenerateWidgetAP(CPDF_Document* pDoc,
bUseFormRes = TRUE;
}
CPDF_Dictionary* pDRFontDict = NULL;
Tom Sepez 2016/03/16 18:34:58 how about: CPDF_Dictionary* pDRFontDict = pDRDict
Wei Li 2016/03/17 02:24:05 Done.
- if (pDRDict && (pDRFontDict = pDRDict->GetDictBy("Font"))) {
+ if (pDRDict && (pDRFontDict = pDRDict->GetDictBy("Font")) != nullptr) {
dsinclair 2016/03/16 13:23:31 What was the issue with this one?
Wei Li 2016/03/16 17:51:31 4706, assignment within conditional expression.
Tom Sepez 2016/03/17 16:40:05 Acknowledged.
pFontDict = pDRFontDict->GetDictBy(sFontName.Mid(1));
if (!pFontDict && !bUseFormRes) {
pDRDict = pFormDict->GetDictBy("DR");
« core/fpdfapi/fpdf_render/fpdf_render_text.cpp ('K') | « core/fpdfapi/fpdf_render/fpdf_render_text.cpp ('k') | core/fpdftext/fpdf_text_int.cpp » ('j') | core/fpdftext/fpdf_text_int.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698