fpdfsdk/formfiller/cba_fontmap.cpp - Issue 1801383002: Re-enable several MSVC warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/formfiller/cba_fontmap.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/formfiller/cba_fontmap.cpp

diff --git a/fpdfsdk/formfiller/cba_fontmap.cpp b/fpdfsdk/formfiller/cba_fontmap.cpp

index 519c7d8cef5d9d2fbc702176eab1c8d912b41e4f..caa0704955abbc2994b7a29b231757b43a1a0388 100644

--- a/fpdfsdk/formfiller/cba_fontmap.cpp

+++ b/fpdfsdk/formfiller/cba_fontmap.cpp

@@ -206,8 +206,8 @@ CPDF_Font* CBA_FontMap::GetAnnotDefaultFont(CFX_ByteString& sAlias) {

}

CFX_ByteString sDA;

- CPDF_Object* pObj;

- if ((pObj = FPDF_GetFieldAttr(m_pAnnotDict, "DA")))

+ CPDF_Object* pObj = FPDF_GetFieldAttr(m_pAnnotDict, "DA");

+ if (pObj)

sDA = pObj->GetString();

if (bWidget) {

« no previous file with comments | « core/fxge/win32/fx_win32_gdipext.cpp ('k') | fpdfsdk/fpdfppo.cpp » ('j') | no next file with comments »