core/fpdfdoc/doc_ap.cpp - Issue 1801383002: Re-enable several MSVC warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_ap.cpp

Issue 1801383002: Re-enable several MSVC warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/doc_ap.cpp

diff --git a/core/fpdfdoc/doc_ap.cpp b/core/fpdfdoc/doc_ap.cpp

index 43dcfb4ac04f70523639e2a25195f8dd8255b928..e64080dbd089486607bc5079c347a836626003d5 100644

--- a/core/fpdfdoc/doc_ap.cpp

+++ b/core/fpdfdoc/doc_ap.cpp

@@ -303,8 +303,8 @@ static FX_BOOL GenerateWidgetAP(CPDF_Document* pDoc,

pDRDict = pFormDict->GetDictBy("DR");

bUseFormRes = TRUE;

}

- CPDF_Dictionary* pDRFontDict = NULL;

- if (pDRDict && (pDRFontDict = pDRDict->GetDictBy("Font"))) {

+ CPDF_Dictionary* pDRFontDict = pDRDict ? pDRDict->GetDictBy("Font") : nullptr;

+ if (pDRFontDict) {

pFontDict = pDRFontDict->GetDictBy(sFontName.Mid(1));

if (!pFontDict && !bUseFormRes) {

pDRDict = pFormDict->GetDictBy("DR");

« no previous file with comments | « core/fpdfapi/fpdf_render/fpdf_render_text.cpp ('k') | core/fxcodec/codec/codec_int.h » ('j') | no next file with comments »